Issue #2462105 by jhedstrom, anmolgoyal74, nexusnovaz, borisson_, berdir,...

Issue #2462105 by jhedstrom, anmolgoyal74, nexusnovaz, borisson_, berdir, mkalkbrenner, fago: Improve failed password hashing exception message

core/lib/Drupal/Core/Field/Plugin/Field/FieldType/PasswordItem.php

@@ -56,7 +56,7 @@ public function preSave() {
       $this->value = \Drupal::service('password')->hash(trim($this->value));
       // Abort if the hashing failed and returned FALSE.
       if (!$this->value) {
-        throw new EntityMalformedException('The entity does not have a password.');
+        throw new EntityMalformedException(sprintf("Failed to hash the %s password.", $entity->getEntityType()->getLabel()));
       }
     }
 

core/tests/Drupal/KernelTests/Core/Field/FieldType/PasswordItemTest.php

@@ -168,7 +168,7 @@ public function testPreSaveExceptionNew(): void {
     $entity = EntityTest::create();
     $entity->test_field = str_repeat('a', PasswordInterface::PASSWORD_MAX_LENGTH + 1);
     $this->expectException(EntityStorageException::class);
-    $this->expectExceptionMessage('The entity does not have a password');
+    $this->expectExceptionMessage('Failed to hash the Test entity password.');
     $entity->save();
   }
 
@@ -183,7 +183,7 @@ public function testPreSaveExceptionExisting(): void {
     $this->assertNotEquals('will_be_hashed', $entity->test_field->value);
 
     $this->expectException(EntityStorageException::class);
-    $this->expectExceptionMessage('The entity does not have a password');
+    $this->expectExceptionMessage('Failed to hash the Test entity password.');
     $entity->test_field = str_repeat('a', PasswordInterface::PASSWORD_MAX_LENGTH + 1);
     $entity->save();
   }