Skip to content
Snippets Groups Projects
Verified Commit 7bafdb1c authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3454212 by nathankg, joachim: Update mentions of #2225961 in comments 

(cherry picked from commit d246c433)
parent ff0f9a93
No related branches found
No related tags found
31 merge requests!10663Issue #3495778: Update phpdoc in FileSaveHtaccessLoggingTest,!10451Issue #3472458 by watergate, smustgrave: CKEditor 5 show blocks label is not translated,!103032838547 Fix punctuation rules for inline label suffix colon with CSS only,!10150Issue #3467294 by quietone, nod_, smustgrave, catch, longwave: Change string...,!10130Resolve #3480321 "Second level menu",!9936Issue #3483087: Check the module:// prefix in the translation server path and replace it with the actual module path,!9933Issue #3394728 by ankondrat4: Undefined array key "#prefix" and deprecated function: explode() in Drupal\file\Element\ManagedFile::uploadAjaxCallback(),!9914Issue #3451136 by quietone, gapple, ghost of drupal past: Improve...,!9882Draft: Issue #3481777 In bulk_form ensure the triggering element is the bulk_form button,!9839Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9815Issue #3480025: There is no way to remove entity cache items,!9757Issue #3478869 Add "All" or overview links to parent links,!9752Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9749Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9678Issue #3465132 by catch, Spokje, nod_: Show test run time by class in run-tests.sh output,!9578Issue #3304746 by scott_euser, casey, smustgrave: BigPipe cannot handle (GET)...,!9449Issue #3344041: Allow textarea widgets to be used for text (formatted) fields,!8945🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥...,!8893Resolve #3444391 "Navigation center sm logo",!8772Issue #3445909 by seanB, smustgrave, alexpott, catch: Add static caching to...,!8723Make dblog entities,!8708Filter out disabled display extenders on save,!8691#3459116 - Update Manager Settings: Validate same email address added multiple times,!8665Issue #3449743 by catch: Try to optimize test ordering when run-tests.sh is...,!8598Draft: Issue #3458215: Migrate Toolbar button to SDC,!8572Reorder checkboxes on "Development settings" page,!8538Issue #3457009: Fixing xxception message thrown.,!8505Issue #3456528: _node_mass_update_batch_process fails during user cancel when revision is deleted,!8494Issue #3452511: Convert ProviderRepositoryTest to a kernel test,!8482Resolve #3456202 "Phpunit tests support",!8463Prevent re-install if site already exists
Pipeline #200751 passed with warnings
Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#200774

    Pipeline: drupal

    #200762

      Pipeline: drupal

      #200755

        Hide whitespace changes
        Inline Side-by-side
        core/lib/Drupal/Core/Entity/EntityFieldManager.php
        + 5
        − 5
        View file @ 7bafdb1c
        ......@@ -277,7 +277,7 @@ protected function buildBaseFieldDefinitions($entity_type_id) {
        $provider = $entity_type->getProvider();
        foreach ($base_field_definitions as $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a proper
        // provider setter. See https://www.drupal.org/node/2225961.
        // provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($provider);
        }
        ......@@ -292,7 +292,7 @@ function (callable $hook, string $module) use (&$base_field_definitions, $entity
        // defining the field.
        foreach ($module_definitions as $field_name => $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a
        // proper provider setter. See https://www.drupal.org/node/2225961.
        // proper provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition && $definition->getProvider() == NULL) {
        $definition->setProvider($module);
        }
        ......@@ -402,7 +402,7 @@ protected function buildBundleFieldDefinitions($entity_type_id, $bundle, array $
        $provider = $entity_type->getProvider();
        foreach ($bundle_field_definitions as $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a proper
        // provider setter. See https://www.drupal.org/node/2225961.
        // provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($provider);
        }
        ......@@ -417,7 +417,7 @@ function (callable $hook, string $module) use (&$bundle_field_definitions, $enti
        // defining the field.
        foreach ($module_definitions as $field_name => $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a
        // proper provider setter. See https://www.drupal.org/node/2225961.
        // proper provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($module);
        }
        ......@@ -594,7 +594,7 @@ function (callable $hook, string $module) use (&$field_definitions, $entity_type
        // defining the field.
        foreach ($module_definitions as $field_name => $definition) {
        // @todo Remove this check once FieldDefinitionInterface exposes a
        // proper provider setter. See https://www.drupal.org/node/2225961.
        // proper provider setter. See https://www.drupal.org/node/2346329.
        if ($definition instanceof BaseFieldDefinition) {
        $definition->setProvider($module);
        $definition->setName($field_name);
        ......
        core/tests/Drupal/Tests/Core/Entity/EntityFieldManagerTest.php
        + 1
        − 1
        View file @ 7bafdb1c
        ......@@ -548,7 +548,7 @@ public function testGetFieldDefinitionsProvider() {
        $module = 'entity_field_manager_test_module';
        // @todo Mock FieldDefinitionInterface once it exposes a proper provider
        // setter. See https://www.drupal.org/node/2225961.
        // setter. See https://www.drupal.org/node/2346329.
        $field_definition = $this->prophesize(BaseFieldDefinition::class);
        // We expect two calls as the field definition will be returned from both
        ......
        0% or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Please register or to comment