Skip to content
Snippets Groups Projects
Verified Commit 67f56fc2 authored by Jess's avatar Jess
Browse files

Issue #3346218 by Kaushik1216, Harlor, urvashi_vora, xjm, pradhumanjain2311,...

Issue #3346218 by Kaushik1216, Harlor, urvashi_vora, xjm, pradhumanjain2311, nayana_mvr, smustgrave, larowlan, catch: Status message on comment edit is 'Your comment has been posted.'
parent e0216370
No related branches found
No related tags found
26 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8373Issue #3427374 by danflanagan8, Vighneshh: taxonomy_tid ViewsArgumentDefault...,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2794Issue #3100732: Allow specifying `meta` data on JSON:API objects,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #149951 canceled
Pipeline: drupal

#149954

    ...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
    use Drupal\Core\Link; use Drupal\Core\Link;
    use Drupal\Core\Render\RendererInterface; use Drupal\Core\Render\RendererInterface;
    use Drupal\Core\Session\AccountInterface; use Drupal\Core\Session\AccountInterface;
    use Drupal\Core\StringTranslation\TranslatableMarkup;
    use Drupal\Core\Url; use Drupal\Core\Url;
    use Symfony\Component\DependencyInjection\ContainerInterface; use Symfony\Component\DependencyInjection\ContainerInterface;
    ...@@ -379,6 +380,7 @@ public function preview(array &$form, FormStateInterface $form_state) { ...@@ -379,6 +380,7 @@ public function preview(array &$form, FormStateInterface $form_state) {
    public function save(array $form, FormStateInterface $form_state) { public function save(array $form, FormStateInterface $form_state) {
    $comment = $this->entity; $comment = $this->entity;
    $entity = $comment->getCommentedEntity(); $entity = $comment->getCommentedEntity();
    $is_new = $this->entity->isNew();
    $field_name = $comment->getFieldName(); $field_name = $comment->getFieldName();
    $uri = $entity->toUrl(); $uri = $entity->toUrl();
    $logger = $this->logger('comment'); $logger = $this->logger('comment');
    ...@@ -392,16 +394,8 @@ public function save(array $form, FormStateInterface $form_state) { ...@@ -392,16 +394,8 @@ public function save(array $form, FormStateInterface $form_state) {
    '%subject' => $comment->getSubject(), '%subject' => $comment->getSubject(),
    'link' => Link::fromTextAndUrl(t('View'), $comment->toUrl()->setOption('fragment', 'comment-' . $comment->id()))->toString(), 'link' => Link::fromTextAndUrl(t('View'), $comment->toUrl()->setOption('fragment', 'comment-' . $comment->id()))->toString(),
    ]); ]);
    // Add an appropriate message upon submitting the comment form.
    // Explain the approval queue if necessary. $this->messenger()->addStatus($this->getStatusMessage($comment, $is_new));
    if (!$comment->isPublished()) {
    if (!$this->currentUser->hasPermission('administer comments')) {
    $this->messenger()->addStatus($this->t('Your comment has been queued for review by site administrators and will be published after approval.'));
    }
    }
    else {
    $this->messenger()->addStatus($this->t('Your comment has been posted.'));
    }
    $query = []; $query = [];
    // Find the current display page for this comment. // Find the current display page for this comment.
    $field_definition = $this->entityFieldManager->getFieldDefinitions($entity->getEntityTypeId(), $entity->bundle())[$field_name]; $field_definition = $this->entityFieldManager->getFieldDefinitions($entity->getEntityTypeId(), $entity->bundle())[$field_name];
    ...@@ -421,4 +415,28 @@ public function save(array $form, FormStateInterface $form_state) { ...@@ -421,4 +415,28 @@ public function save(array $form, FormStateInterface $form_state) {
    $form_state->setRedirectUrl($uri); $form_state->setRedirectUrl($uri);
    } }
    /**
    * Gets an appropriate status message when a comment is saved.
    *
    * @param \Drupal\comment\CommentInterface $comment
    * The comment being saved.
    * @param bool $is_new
    * TRUE if a new comment is created. $comment->isNew() cannot be used here
    * because the comment has already been saved by the time the message is
    * rendered.
    *
    * @return \Drupal\Core\StringTranslation\TranslatableMarkup
    * A translatable string containing the appropriate status message.
    */
    protected function getStatusMessage(CommentInterface $comment, bool $is_new): TranslatableMarkup {
    if (!$comment->isPublished() && !$this->currentUser->hasPermission('administer comments')) {
    return $this->t('Your comment has been queued for review by site administrators and will be published after approval.');
    }
    // Check whether the comment is new or not.
    if ($is_new) {
    return $this->t('Your comment has been posted.');
    }
    return $this->t('Your comment has been updated.');
    }
    } }
    ...@@ -178,7 +178,7 @@ public function testCommentEditPreviewSave() { ...@@ -178,7 +178,7 @@ public function testCommentEditPreviewSave() {
    // Check that saving a comment produces a success message. // Check that saving a comment produces a success message.
    $this->drupalGet('comment/' . $comment->id() . '/edit'); $this->drupalGet('comment/' . $comment->id() . '/edit');
    $this->submitForm($edit, 'Save'); $this->submitForm($edit, 'Save');
    $this->assertSession()->pageTextContains('Your comment has been posted.'); $this->assertSession()->pageTextContains('Your comment has been updated.');
    // Check that the comment fields are correct after loading the saved comment. // Check that the comment fields are correct after loading the saved comment.
    $this->drupalGet('comment/' . $comment->id() . '/edit'); $this->drupalGet('comment/' . $comment->id() . '/edit');
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment