Skip to content
Snippets Groups Projects
Commit 5ce1a1b4 authored by catch's avatar catch
Browse files

Issue #3417362 by kristiaanvandeneynde, smustgrave, quietone: Call...

Issue #3417362 by kristiaanvandeneynde, smustgrave, quietone: Call refreshVariables() where needed in various tests
parent 7a286515
No related branches found
No related tags found
30 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8373Issue #3427374 by danflanagan8, Vighneshh: taxonomy_tid ViewsArgumentDefault...,!7526Expose roles in response,!7352Draft: Resolve #3203489 "Set filename as",!6791Issue #3163299: Ajax exposed filters not working for multiple instances of the same Views block placed on one page,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2794Issue #3100732: Allow specifying `meta` data on JSON:API objects,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #104223 canceled
Pipeline: drupal

#104224

    ......@@ -359,6 +359,9 @@ public function testPostSkipCommentApproval() {
    $this->assertResourceResponse(201, FALSE, $response);
    $this->assertFalse($unserialized->isPublished());
    // Make sure the role save below properly invalidates cache tags.
    $this->refreshVariables();
    // Grant anonymous permission to skip comment approval.
    $this->grantPermissionsToTestedRole(['skip comment approval']);
    ......
    ......@@ -86,6 +86,9 @@ public function testMediaOverviewPage() {
    ]);
    $media3->save();
    // Make sure the role save below properly invalidates cache tags.
    $this->refreshVariables();
    // Verify the view is now correctly populated. The non-admin user can only
    // view published media.
    $this->grantPermissions($role, [
    ......@@ -138,6 +141,9 @@ public function testMediaOverviewPage() {
    $assert_session->elementExists('css', 'td.views-field-operations li a:contains("Delete")', $row1);
    $assert_session->linkByHrefExists('/media/' . $media1->id() . '/delete');
    // Make sure the role save below properly invalidates cache tags.
    $this->refreshVariables();
    // Make the user the owner of the unpublished media item and assert the
    // media item is only visible with the 'view own unpublished media'
    // permission.
    ......
    ......@@ -375,6 +375,9 @@ protected function uploadFile() {
    static::recursiveKSort($actual);
    $this->assertSame($expected, $actual);
    // Make sure the role save below properly invalidates cache tags.
    $this->refreshVariables();
    // To still run the complete test coverage for POSTing a Media entity, we
    // must revoke the additional permissions that we granted.
    $role = Role::load(static::$auth ? RoleInterface::AUTHENTICATED_ID : RoleInterface::ANONYMOUS_ID);
    ......
    ......@@ -255,6 +255,9 @@ public function testPatchPath() {
    $this->assertSame('/llama', $this->entityStorage->loadUnchanged($this->entity->id())->get('path')->alias);
    $this->assertResourceErrorResponse(403, "Access denied on updating field 'path'. " . static::$patchProtectedFieldNames['path'], $response);
    // Make sure the role save below properly invalidates cache tags.
    $this->refreshVariables();
    // Grant permission to create URL aliases.
    $this->grantPermissionsToTestedRole(['create url aliases']);
    ......
    • catch @catch

      mentioned in commit 722d8fba

      ·

      mentioned in commit 722d8fba

      Toggle commit list
    • catch @catch

      mentioned in commit a16476ec

      ·

      mentioned in commit a16476ec

      Toggle commit list
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment