Skip to content
Snippets Groups Projects
Verified Commit 5923aeae authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3371937 by yash.rode, Abhijith S, smustgrave, fgm: Theme declaration...

Issue #3371937 by yash.rode, Abhijith S, smustgrave, fgm: Theme declaration and templates mismatch for feed_icon

(cherry picked from commit 01da0fd9)
parent 0bc782b1
Branches
Tags
41 merge requests!10663Issue #3495778: Update phpdoc in FileSaveHtaccessLoggingTest,!10451Issue #3472458 by watergate, smustgrave: CKEditor 5 show blocks label is not translated,!103032838547 Fix punctuation rules for inline label suffix colon with CSS only,!10150Issue #3467294 by quietone, nod_, smustgrave, catch, longwave: Change string...,!10130Resolve #3480321 "Second level menu",!9936Issue #3483087: Check the module:// prefix in the translation server path and replace it with the actual module path,!9933Issue #3394728 by ankondrat4: Undefined array key "#prefix" and deprecated function: explode() in Drupal\file\Element\ManagedFile::uploadAjaxCallback(),!9914Issue #3451136 by quietone, gapple, ghost of drupal past: Improve...,!9882Draft: Issue #3481777 In bulk_form ensure the triggering element is the bulk_form button,!9839Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9815Issue #3480025: There is no way to remove entity cache items,!9757Issue #3478869 Add "All" or overview links to parent links,!9752Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9749Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9678Issue #3465132 by catch, Spokje, nod_: Show test run time by class in run-tests.sh output,!9578Issue #3304746 by scott_euser, casey, smustgrave: BigPipe cannot handle (GET)...,!9449Issue #3344041: Allow textarea widgets to be used for text (formatted) fields,!8945🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥...,!8893Resolve #3444391 "Navigation center sm logo",!8772Issue #3445909 by seanB, smustgrave, alexpott, catch: Add static caching to...,!8723Make dblog entities,!8708Filter out disabled display extenders on save,!8691#3459116 - Update Manager Settings: Validate same email address added multiple times,!8665Issue #3449743 by catch: Try to optimize test ordering when run-tests.sh is...,!8598Draft: Issue #3458215: Migrate Toolbar button to SDC,!8572Reorder checkboxes on "Development settings" page,!8538Issue #3457009: Fixing xxception message thrown.,!8516Update file EntityReferenceItem.php,!8505Issue #3456528: _node_mass_update_batch_process fails during user cancel when revision is deleted,!8494Issue #3452511: Convert ProviderRepositoryTest to a kernel test,!8482Resolve #3456202 "Phpunit tests support",!8463Prevent re-install if site already exists,!8392Issue #3454196: Filter placeholders without arguments are not replaced when HTML corrector filter applied afterwards,!8384Issue #3446403 by edutrul, jnicola, mradcliffe: [name]: This field is missing for example recipe,!8304Issue #2990766 by camilledavis, Gauravvvv, mgifford: Location of "Skip to...,!8178Issue #3439909 by SolimanHarkas, vensires: Fix Taxonomy tests that rely on...,!8138Remove inactive initiatives from maintainers list,!8078Issue #3439909 by SolimanHarkas, vensires: Fix Taxonomy tests that rely on...,!8065Adds Default Content and Recipes Subsystems,!8047Issue #3439909 by SolimanHarkas, vensires: Fix Taxonomy tests that rely on...,!5829Porting tabledrag CSS refactor from D10 branch
Pipeline #171310 passed
...@@ -1890,7 +1890,7 @@ function drupal_common_theme() { ...@@ -1890,7 +1890,7 @@ function drupal_common_theme() {
'variables' => ['items' => [], 'title' => '', 'list_type' => 'ul', 'wrapper_attributes' => [], 'attributes' => [], 'empty' => NULL, 'context' => []], 'variables' => ['items' => [], 'title' => '', 'list_type' => 'ul', 'wrapper_attributes' => [], 'attributes' => [], 'empty' => NULL, 'context' => []],
], ],
'feed_icon' => [ 'feed_icon' => [
'variables' => ['url' => NULL, 'title' => NULL], 'variables' => ['url' => NULL, 'title' => NULL, 'attributes' => []],
], ],
'progress_bar' => [ 'progress_bar' => [
'variables' => ['label' => NULL, 'percent' => NULL, 'message' => NULL], 'variables' => ['label' => NULL, 'percent' => NULL, 'message' => NULL],
......
...@@ -99,4 +99,20 @@ public function testFeedIconEscaping() { ...@@ -99,4 +99,20 @@ public function testFeedIconEscaping() {
$this->assertEquals('Subscribe to <>&"'', trim(strip_tags($text)), 'feed_icon template escapes reserved HTML characters.'); $this->assertEquals('Subscribe to <>&"'', trim(strip_tags($text)), 'feed_icon template escapes reserved HTML characters.');
} }
/**
* Tests that the rendered output contains specific attributes.
*/
public function testAttributeAdded(): void {
$variables = [
'#theme' => 'feed_icon',
'#url' => 'node/add/',
'#title' => 'testing title',
'#attributes' => ['title' => 'some title', 'class' => ['some-class']],
];
$rendered_output = (string) \Drupal::service('renderer')->renderRoot($variables);
// Check if the class 'some-class' is present in the rendered output.
$this->assertStringContainsString('some-class', $rendered_output, "The class 'some-class' should be present in the rendered output.");
}
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment