Skip to content
Snippets Groups Projects

Issue #3454196: Filter placeholders without arguments are not replaced when HTML corrector filter applied afterwards

Closed Issue #3454196: Filter placeholders without arguments are not replaced when HTML corrector filter applied afterwards
issue/drupal-3454196:3454196-filter-placeholders-without into 11.x
1 unresolved thread
Closed James Williams requested to merge issue/drupal-3454196:3454196-filter-placeholders-without into 11.x
1 unresolved thread

Issue #3454196: Filter placeholders without arguments are not replaced when HTML corrector filter applied afterwards

Closes #3454196

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/lib/Drupal/Component/Utility/HtmlSerializerRules.php
22 27 */
23 28 class HtmlSerializerRules extends OutputRules {
24 29
30 /**
31 * {@inheritdoc}
32 */
33 public function __construct($output, $options = []) {
34 parent::__construct($output, $options);
35
36 $this->addRule([
37 'nodeName' => 'drupal-filter-placeholder',
38 'attrName' => 'arguments',
39 ]);
  • Comment on lines +36 to +39
    James Williams
    James Williams @jameswilliams ·
    Author

    I can believe there should be a better place for this change. At the moment, this \Drupal\Component\Utility\HtmlSerializerRules class is only used within \Drupal\Component\Utility\Html::serialize(), but maybe there should be a factory service for it, which could allow other modules to act on instantiation? That feels like a much bigger change than I was anticipating, but I'll defer to any greater wisdom anyone can offer :)

  • Please register or sign in to reply
  • Stephen Mustgrave
  • James Williams added 1 commit

    added 1 commit

    • 1e8d32f2 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • James Williams changed target branch from 11.0.x to 11.x

    changed target branch from 11.0.x to 11.x

  • James Williams added 175 commits

    added 175 commits

    • 1e8d32f2...62f9af40 - 174 commits from branch project:11.x
    • 1df82d18 - Merge branch '11.x' into drupal-3454196-3454196-filter-placeholders-without

    Compare with previous version

  • James Williams closed

    closed

  • James Williams
    James Williams @jameswilliams ·
    Author

    I'm going to give up attempting to repoint this MR at 11.x and just spin up a new MR.

    • Please register or sign in to reply