Skip to content
Snippets Groups Projects
Commit 285eb15b authored by catch's avatar catch
Browse files

Issue #3443959: DialogRenderer::getTitleAsStringable() does not support all...

Issue #3443959: DialogRenderer::getTitleAsStringable() does not support all return types of TitleResolverInterface::getTitle()

(cherry picked from commit 4a4a78b5)
parent 256f5942
No related branches found
Tags 1.0.0-alpha19
17 merge requests!10602Issue #3438769 by vinmayiswamy, antonnavi, michelle, amateescu: Sub workspace does not clear,!10301Issue #3469309 by mstrelan, smustgrave, moshe weitzman: Use one-time login...,!10187Issue #3487488 by dakwamine: ExtensionMimeTypeGuesser::guessMimeType must support file names with "0" (zero) like foo.0.zip,!9929Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9787Resolve issue 3479427 - bootstrap barrio issue under Windows,!9742Issue #3463908 by catch, quietone: Split OptionsFieldUiTest into two,!9526Issue #3458177 by mondrake, catch, quietone, godotislate, longwave, larowlan,...,!8949Backport .gitlabci.yml changes.,!8738Issue #3424162 by camilledavis, dineshkumarbollu, smustgrave: Claro...,!8704Make greek characters available in ckeditor5,!8597Draft: Issue #3442259 by catch, quietone, dww: Reduce time of Migrate Upgrade tests...,!8533Issue #3446962 by kim.pepper: Remove incorrectly added...,!8517Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false positive,!7445Issue #3440169: When using drupalGet(), provide an associative array for $headers,!6502Draft: Resolve #2938524 "Plach testing issue",!38582585169-10.1.x,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key
Checking pipeline status
......@@ -132,17 +132,9 @@ protected function getDialogOptions(Request $request): array {
* The title as a string or stringable object.
*/
protected function getTitleAsStringable(array $main_content, Request $request, RouteMatchInterface $route_match): \Stringable|string|null {
$title = NULL;
if (array_key_exists('#title', $main_content)) {
if (is_array($main_content['#title'])) {
$title = $this->renderer->renderInIsolation($main_content['#title']);
}
else {
$title = $main_content['#title'];
}
}
elseif ($this->titleResolver->getTitle($request, $route_match->getRouteObject())) {
$title = $this->titleResolver->getTitle($request, $route_match->getRouteObject())->render();
$title = $main_content['#title'] ?? $this->titleResolver->getTitle($request, $route_match->getRouteObject());
if (is_array($title)) {
$title = $this->renderer->renderInIsolation($title);
}
return $title;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment