Skip to content
Snippets Groups Projects
Verified Commit 1bcfd82c authored by Lee Rowlands's avatar Lee Rowlands
Browse files

Issue #3419352 by acbramley: DatabaseBackend doesn't handle string typed $max_rows with $serializer

parent 870e5c1c
No related branches found
No related tags found
27 merge requests!12227Issue #3181946 by jonmcl, mglaman,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!3878Removed unused condition head title for views,!38582585169-10.1.x,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3668Resolve #3347842 "Deprecate the trusted",!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3478Issue #3337882: Deleted menus are not removed from content type config,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #89750 canceled
Pipeline: drupal

#89751

    ......@@ -83,20 +83,26 @@ class DatabaseBackend implements CacheBackendInterface {
    * The cache tags checksum provider.
    * @param string $bin
    * The cache bin for which the object is created.
    * @param \Drupal\Component\Serialization\ObjectAwareSerializationInterface|int|null $serializer
    * @param \Drupal\Component\Serialization\ObjectAwareSerializationInterface|int|string|null $serializer
    * (optional) The serializer to use.
    * @param int $max_rows
    * (optional) The maximum number of rows that are allowed in this cache bin
    * table.
    */
    public function __construct(Connection $connection, CacheTagsChecksumInterface $checksum_provider, $bin, ObjectAwareSerializationInterface|int $serializer = NULL, $max_rows = NULL) {
    public function __construct(
    Connection $connection,
    CacheTagsChecksumInterface $checksum_provider,
    $bin,
    ObjectAwareSerializationInterface|int|string|null $serializer = NULL,
    $max_rows = NULL,
    ) {
    // All cache tables should be prefixed with 'cache_'.
    $bin = 'cache_' . $bin;
    $this->bin = $bin;
    $this->connection = $connection;
    $this->checksumProvider = $checksum_provider;
    if (is_int($serializer)) {
    if (is_int($serializer) || is_string($serializer)) {
    @trigger_error('Calling ' . __METHOD__ . ' with the $max_rows as 3rd argument is deprecated in drupal:10.3.0 and it will be the 4th argument in drupal:11.0.0. See https://www.drupal.org/node/3014684', E_USER_DEPRECATED);
    $max_rows = $serializer;
    $serializer = \Drupal::service('serialization.phpserialize');
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment