# By git
# Via git
* 'mads-30' of bitbucket.org:messageagency/sf:
  Fixes various issues causing unit tests to fail

Conflicts:
	modules/salesforce_mapping/src/Entity/SalesforceMappingInterface.php

Removes most method blueprints from SalesforceMappingInterface to remove
bizarre abstract method errors in phpUnit
Fixes object instantian test in SalesforeMappingTest

PullBase not in a good state, still needs major attention, but moving to lower-level tests for entities before proceeding there
MappedObjectTest setUp method implemented; stubs for push, pushDelete, and pull tests

# By git
# Via git
* 'mads-30' of bitbucket.org:messageagency/sf:
  Cleans up SalesForceMappingInterface

# By git
# Via git
* 'mads-30' of bitbucket.org:messageagency/sf:
  End of week commit Adds DeleteHandlerTest (not quite working yet) Removes injected Url object in RestClient. There is no @url service in core.services.yml and we’re not supposed to use UrlGenerator. Since Url is only used once in RestClient::getAuthCallbackUrl(), Url is used directly and that method can be easily mocked under test. Cleans up salesforce_pull_cron() Cleans up DeleteHandler’s use statements Adds Request object to DeleteHandler’s constructor to handle REQUEST_TIME server global Adds boolean returns to DeleteHandler methods for unit testing purposes Fixes camel casing in MappedObjectStorage::loadBySfid() call in DeleteHandler Converts try/catch pairs in DeleteHandler to non-exception based conditional logic to make logic testable Cleans up PullBase’s use statements Adds event dispatcher service to PullBase’s constructor Removes some property reference discrepancies in PullBase Removes unnecessary code from PullBaseTest Removes unnecessary code from QueueHandlerTest Adds back in missing properties in a loadByProperties call in salesforce_push.module Adds logger.factory service to PushQueue’s service definition in salesforce_push.services.yml Changes logger service injection in PushQueue’s constructor to logger.factory service (there is no logger service defined in core.services.yml) Fixes all logger service references in PushQueue Cleans up SalesforcePushQueueProcessor/Rest’s use statements Removes EntityManager service injection in SalesforcePushQueueProcessor/Rest’s constructor in favor of already existing EntityTypeManager service

Conflicts:
	modules/salesforce_pull/src/Plugin/QueueWorker/PullBase.php
	modules/salesforce_pull/tests/src/Unit/PullBaseTest.php
	modules/salesforce_push/src/Plugin/SalesforcePushQueueProcessor/Rest.php

Adds DeleteHandlerTest (not quite working yet)
Removes injected Url object in RestClient. There is no @url service in core.services.yml and we’re
not supposed to use UrlGenerator. Since Url is only used once in RestClient::getAuthCallbackUrl(),
Url is used directly and that method can be easily mocked under test.
Cleans up salesforce_pull_cron()
Cleans up DeleteHandler’s use statements
Adds Request object to DeleteHandler’s constructor to handle REQUEST_TIME server global
Adds boolean returns to DeleteHandler methods for unit testing purposes
Fixes camel casing in MappedObjectStorage::loadBySfid() call in DeleteHandler
Converts try/catch pairs in DeleteHandler to non-exception based conditional logic to make logic
testable
Cleans up PullBase’s use statements
Adds event dispatcher service to PullBase’s constructor
Removes some property reference discrepancies in PullBase
Removes unnecessary code from PullBaseTest
Removes unnecessary code from QueueHandlerTest
Adds back in missing properties in a loadByProperties call in salesforce_push.module
Adds logger.factory service to PushQueue’s service definition in salesforce_push.services.yml
Changes logger service injection in PushQueue’s constructor to logger.factory service (there is
no logger service defined in core.services.yml)
Fixes all logger service references in PushQueue
Cleans up SalesforcePushQueueProcessor/Rest’s use statements
Removes EntityManager service injection in SalesforcePushQueueProcessor/Rest’s
constructor in favor of already existing EntityTypeManager service

Still to do:
DeletehandlerTest needs to pass - A deep property call is not working, causing the test to
error out.
Fix DeleteHandler’s call to property so it’s easier to mock under test
Address Warning: array_flip(): Can only flip STRING and INTEGER values! error in or around
SalesForcePullEvent
Fix PullBase’s multiple creation of same new Drupal entity (was fixed, now showing up again).

testProcessItemCreate() now test using the non-Exception based login in PullBase::processItem().
Assertion test added to ensure mapped object passed is empty to trigger create logic
continue statement commented out (to be removed most likely) to address following error:
PHP Fatal error:  'continue' not in the 'loop' or 'switch' context in
sfsuite/modules/contrib/salesforce/modules/salesforce_pull/src/Plugin/QueueWorker/PullBase.php
on line 166

- Repurpose EntityNotFoundException to be used only (currently) during push queue processing
- Rewrite salesforce_push_load_push_mappings() as method of SalesforceMappingStorage

# By git
# Via git
* 'mads-30' of bitbucket.org:messageagency/sf:
  Fixes same syntax error in RestClient as last commit, but also cleans up the injected service.

Conflicts:
	modules/salesforce_pull/tests/src/Unit/PullBaseTest.php

Still a problem with PullBaseTest

can find them

* 8.x-3.x:
  "Exception" typo

Removes needs for TestQueueHandler test class by
- adding state, request, and logger classes to QueueHandler constructor (injected)
- converting watchdog_exception calls to injected logger calls (also removes need to
  use LoggerTrait)
- stubs and overrides the parseUrl methods in a mock QueueHanlder class in the
  test code
Fixes a null object error with a trinary in PullBase
Does not fix all PullBase tests

# Conflicts:
#	modules/salesforce_pull/src/DeleteHandler.php
#	modules/salesforce_pull/src/Plugin/QueueWorker/PullBase.php

PullBaseTest needs work.
TestPullBase removed - test version of class no longer needed.
Removes all calls to watchdog_exception in PullBase, injected logger used
instead.
Adds LoggerFactory dependency into PullBase constructor and create()
method.
Removes wrapper functions now using injected storage classes (already testable!).
Adds full logger mocking to PullBaseTest.
Adds .tags to .gitignore

Adds missing use statements to MappedObject
Adds missing use statements to PullBase
Removes unnecessary EntityManager dependency to PullBase; EntityTypeManager
already exists

Fixes injected service call in PushQueue

Overrides SalesforceMapping’s inherited postLoad method to attach