End of week commit

Adds DeleteHandlerTest (not quite working yet)
Removes injected Url object in RestClient. There is no @url service in core.services.yml and we’re
not supposed to use UrlGenerator. Since Url is only used once in RestClient::getAuthCallbackUrl(),
Url is used directly and that method can be easily mocked under test.
Cleans up salesforce_pull_cron()
Cleans up DeleteHandler’s use statements
Adds Request object to DeleteHandler’s constructor to handle REQUEST_TIME server global
Adds boolean returns to DeleteHandler methods for unit testing purposes
Fixes camel casing in MappedObjectStorage::loadBySfid() call in DeleteHandler
Converts try/catch pairs in DeleteHandler to non-exception based conditional logic to make logic
testable
Cleans up PullBase’s use statements
Adds event dispatcher service to PullBase’s constructor
Removes some property reference discrepancies in PullBase
Removes unnecessary code from PullBaseTest
Removes unnecessary code from QueueHandlerTest
Adds back in missing properties in a loadByProperties call in salesforce_push.module
Adds logger.factory service to PushQueue’s service definition in salesforce_push.services.yml
Changes logger service injection in PushQueue’s constructor to logger.factory service (there is
no logger service defined in core.services.yml)
Fixes all logger service references in PushQueue
Cleans up SalesforcePushQueueProcessor/Rest’s use statements
Removes EntityManager service injection in SalesforcePushQueueProcessor/Rest’s
constructor in favor of already existing EntityTypeManager service

Still to do:
DeletehandlerTest needs to pass - A deep property call is not working, causing the test to
error out.
Fix DeleteHandler’s call to property so it’s easier to mock under test
Address Warning: array_flip(): Can only flip STRING and INTEGER values! error in or around
SalesForcePullEvent
Fix PullBase’s multiple creation of same new Drupal entity (was fixed, now showing up again).