Skip to content
Snippets Groups Projects
Commit 5106b04e authored by Aaron Bauman's avatar Aaron Bauman
Browse files

Merge branch 'mads-30' of bitbucket.org:messageagency/sf into mads-30

# By git
# Via git
* 'mads-30' of bitbucket.org:messageagency/sf:
  End of week commit Adds DeleteHandlerTest (not quite working yet) Removes injected Url object in RestClient. There is no @url service in core.services.yml and we’re not supposed to use UrlGenerator. Since Url is only used once in RestClient::getAuthCallbackUrl(), Url is used directly and that method can be easily mocked under test. Cleans up salesforce_pull_cron() Cleans up DeleteHandler’s use statements Adds Request object to DeleteHandler’s constructor to handle REQUEST_TIME server global Adds boolean returns to DeleteHandler methods for unit testing purposes Fixes camel casing in MappedObjectStorage::loadBySfid() call in DeleteHandler Converts try/catch pairs in DeleteHandler to non-exception based conditional logic to make logic testable Cleans up PullBase’s use statements Adds event dispatcher service to PullBase’s constructor Removes some property reference discrepancies in PullBase Removes unnecessary code from PullBaseTest Removes unnecessary code from QueueHandlerTest Adds back in missing properties in a loadByProperties call in salesforce_push.module Adds logger.factory service to PushQueue’s service definition in salesforce_push.services.yml Changes logger service injection in PushQueue’s constructor to logger.factory service (there is no logger service defined in core.services.yml) Fixes all logger service references in PushQueue Cleans up SalesforcePushQueueProcessor/Rest’s use statements Removes EntityManager service injection in SalesforcePushQueueProcessor/Rest’s constructor in favor of already existing EntityTypeManager service

Conflicts:
	modules/salesforce_pull/src/Plugin/QueueWorker/PullBase.php
	modules/salesforce_pull/tests/src/Unit/PullBaseTest.php
	modules/salesforce_push/src/Plugin/SalesforcePushQueueProcessor/Rest.php
parents 0c789be6 d13572d8
No related branches found
No related tags found
Loading
Showing
with 269 additions and 93 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment