Skip to content
Snippets Groups Projects

Changes for removal of DrupalCI.

Merged Changes for removal of DrupalCI.
issue/project_browser-3427491:3427491-disable-drupalci into 1.0.x
1 open thread
Merged
James Shieldsrequested to merge
issue/project_browser-3427491:3427491-disable-drupalci into 1.0.x
1 open thread

Removed files no longer needed. Made changes for PHPStan and CSpell. Tidied comments referencing DrupalCI. Closes #3427491

Merge request reports

Merge request pipeline #129982 failed

Stage: build
Stage: validate
Stage: test

Merge request pipeline failed for f14352bb

Code Quality is loading
Test summary results are being parsed
Full report

Merged by Chris WellsChris Wells Mar 27, 2024 (Mar 27, 2024 3:17pm UTC)

Loading

Pipeline #130688 failed

Stage: build
Stage: validate
Stage: test

Pipeline failed for 42876977 on 1.0.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
phpstan.neon.dist
1 1 includes:
2 - %rootDir%/../../../core/phpstan.neon.dist
2 - %rootDir%/../../../web/core/phpstan.neon.dist
  • Chris Wells
    Chris Wells @cwells
    Maintainer

    Why is this change specifically needed for this particular MR? Or are we trying to fix two issues with one MR?

  • James Shields
    James Shields @lostcarpark
    Author

    This change is needed because DrupalCI needed the path to exclude web/, but GitLabCI requires it.

    To allow the same phpstan.neon file to be used by both, I ran a sed update in before script of the GitLabCI one.

    As DrupalCI is being removed, the sed command can be removed, and the change made permanent in phpstan.neon.

  • Please register or sign in to reply
  • Chris Wells merged

    merged

    • Please register or sign in to reply