Skip to content
Snippets Groups Projects

Issue #3328136: InstallerController::activateModule() assumes project id and extension ID will match

Open Issue #3328136: InstallerController::activateModule() assumes project id and extension ID will match
issue/project_browser-3328136:3328136-installercontrolleractivatemodule-assumes-project into 1.0.x
2 open threads
Open
Narendra Singh Rathorerequested to merge
issue/project_browser-3328136:3328136-installercontrolleractivatemodule-assumes-project into 1.0.x
2 open threads
Compare
and
5 files
+ 288
− 8
Compare changes
  • Side-by-side
  • Inline

Files

src/ComposerInstaller/Installer.php
+ 1
− 1
@@ -27,7 +27,7 @@ use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
@@ -27,7 +27,7 @@ use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
* at any time without warning. External code should not interact with this
* at any time without warning. External code should not interact with this
* class.
* class.
*/
*/
final class Installer extends Stage {
class Installer extends Stage {
    • Comment on lines -30 to +30
      Tim Plunkett
      Tim Plunkett @tim.plunkett
      Maintainer

      The parent class isn't final, nor are any of the other subclasses of Stage. Core typically uses final for utilities, value objects, and event-related classes. I don't think it's necessary to have here, and it is a hard-blocker for writing unit tests

Please register or sign in to reply
/**
/**
* {@inheritdoc}
* {@inheritdoc}