Skip to content
Snippets Groups Projects

Issue #3328136: InstallerController::activateModule() assumes project id and extension ID will match

Open Issue #3328136: InstallerController::activateModule() assumes project id and extension ID will match

Merge request reports

Members who can merge are allowed to add commits.
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
27 27 * at any time without warning. External code should not interact with this
28 28 * class.
29 29 */
30 final class Installer extends Stage {
30 class Installer extends Stage {
  • Comment on lines -30 to +30

    The parent class isn't final, nor are any of the other subclasses of Stage. Core typically uses final for utilities, value objects, and event-related classes. I don't think it's necessary to have here, and it is a hard-blocker for writing unit tests

  • Please register or sign in to reply
  • 107 protected $moduleList;
    108
    109 /**
    110 * The info files finder service.
    111 *
    112 * @var \Drupal\project_browser\InfoFilesFinder
    113 */
    114 protected $infoFilesFinder;
    115
    101 116 /**
    102 117 * Constructs an InstallerController object.
    103 118 *
    104 119 * @param \Drupal\project_browser\ComposerInstaller\Installer $installer
    105 120 * The installer.
    106 * @param \Drupal\package_manager\PathLocator $path_locator
    107 * The path locator service.
  • added 5 commits

    • 75af2718...0be9f815 - 3 commits from branch project:1.0.x
    • 973b2007 - Merge branch '1.0.x' into 3328136-installercontrolleractivatemodule-assumes-project
    • 0267922c - Comment added

    Compare with previous version

  • Tim Plunkett added 14 commits

    added 14 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading