Skip to content
Snippets Groups Projects

#3453152: Centralize & standardize logic for constructing `*PropSource` objects

Merged #3453152: Centralize & standardize logic for constructing `*PropSource` objects
All threads resolved!
All threads resolved!

Closes #3453152.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lee Rowlands
  • Lee Rowlands
  • Wim Leers resolved all threads

    resolved all threads

  • Wim Leers added 1 commit

    added 1 commit

    Compare with previous version

  • Author Maintainer

    Excellent remarks, @larowlan, thanks :blush: I believe it's ready now.

  • Wim Leers requested review from @larowlan

    requested review from @larowlan

  • Ted Bowman added 21 commits

    added 21 commits

    Compare with previous version

  • I'm ok with the work in this branch. I'm still not convinced the prop source concept is the right way to go, I think we should be using a data structure instead of magic strings/separators. We have json, we should use it. The cognitive overhead of reading these is too high.

  • Wim Leers added 5 commits

    added 5 commits

    • d779963a...9ea7001f - 4 commits from branch project:0.x
    • e215e502 - Merge remote-tracking branch 'origin/0.x' into 3453152-propsource-parsing

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 0501d96f - Tighten PHPStan types, and provide type aliases:...

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • b5cf3043 - Always use `JSON_UNESCAPED_UNICODE`.

    Compare with previous version

  • Wim Leers added 1 commit

    added 1 commit

    • 18933c9c - Add test coverage to A) reduce the concerns voiced by @larowlan, B) empower...

    Compare with previous version

  • Wim Leers added 2 commits

    added 2 commits

    Compare with previous version

  • Wim Leers added 2 commits

    added 2 commits

    • fdab62d1 - Update the assertion for an `AdaptedPropSource` in `EndToEndDemoIntegrationTest`.
    • 8b33e522 - Make `EndToEndDemoIntegrationTest` point to `PropSourceTest`.

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading