#3453152: Centralize & standardize logic for constructing `*PropSource` objects
All threads resolved!
All threads resolved!
Closes #3453152.
Merge request reports
Activity
Filter activity
assigned to @wimleers
requested review from @larowlan
added 1 commit
- 74a973e6 - Rename `PropSource` to `PropSourceBase`, introduce...
added 6 commits
-
16728ff4...86306615 - 4 commits from branch
project:0.x
- 9ae55e4e - Rename `PropSource` to `PropSourceBase`, introduce...
- 3283382e - `phpstan`
-
16728ff4...86306615 - 4 commits from branch
- Resolved by Wim Leers
- Resolved by Wim Leers
- Resolved by Wim Leers
Excellent remarks, @larowlan, thanks
I believe it's ready now.requested review from @larowlan
added 21 commits
-
27307ec3...29100956 - 20 commits from branch
project:0.x
- d779963a - Merge branch '0.x' into 3453152-propsource-parsing
-
27307ec3...29100956 - 20 commits from branch
I'm ok with the work in this branch. I'm still not convinced the prop source concept is the right way to go, I think we should be using a data structure instead of magic strings/separators. We have json, we should use it. The cognitive overhead of reading these is too high.
added 5 commits
-
d779963a...9ea7001f - 4 commits from branch
project:0.x
- e215e502 - Merge remote-tracking branch 'origin/0.x' into 3453152-propsource-parsing
-
d779963a...9ea7001f - 4 commits from branch
added 1 commit
- 0501d96f - Tighten PHPStan types, and provide type aliases:...
added 1 commit
added 2 commits
Please register or sign in to reply