Issue #2959551 by quietone, kaythay, nikhil_110, alexpott, smustgrave,...

Issue #2959551 by quietone, kaythay, nikhil_110, alexpott, smustgrave, tstoeckler: Variable::export should export using short-hand array syntax

core/lib/Drupal/Component/Utility/Variable.php

@@ -50,16 +50,16 @@ public static function callableToString($callable): string {
   public static function export($var, $prefix = '') {
     if (is_array($var)) {
       if (empty($var)) {
-        $output = 'array()';
+        $output = '[]';
       }
       else {
-        $output = "array(\n";
+        $output = "[\n";
         // Don't export keys if the array is non associative.
         $export_keys = array_values($var) != $var;
         foreach ($var as $key => $value) {
           $output .= '  ' . ($export_keys ? static::export($key) . ' => ' : '') . static::export($value, '  ') . ",\n";
         }
-        $output .= ')';
+        $output .= ']';
       }
     }
     elseif (is_bool($var)) {
@@ -85,6 +85,8 @@ public static function export($var, $prefix = '') {
       $output = '(object) ' . static::export((array) $var, $prefix);
     }
     else {
+      // @todo var_export() does not use long array syntax. Fix in
+      // https://www.drupal.org/project/drupal/issues/3476894
       $output = var_export($var, TRUE);
     }
 

core/modules/migrate/tests/src/Unit/process/ExtractTest.php

@@ -47,7 +47,7 @@ public function testExtractInvalid($value): void {
    */
   public function testExtractFail(): void {
     $this->expectException(MigrateException::class);
-    $this->expectExceptionMessage("Array index missing, extraction failed for 'array(\n  'bar' => 'foo',\n)'. Consider adding a `default` key to the configuration.");
+    $this->expectExceptionMessage("Array index missing, extraction failed for '[\n  'bar' => 'foo',\n]'. Consider adding a `default` key to the configuration.");
     $this->plugin->transform(['bar' => 'foo'], $this->migrateExecutable, $this->row, 'destination_property');
   }
 

core/tests/Drupal/Tests/Component/Utility/VariableTest.php

@@ -95,17 +95,17 @@ public static function providerTestExport() {
     return [
       // Array.
       [
-        'array()',
+        '[]',
         [],
       ],
       [
         // non-associative.
-        "array(\n  1,\n  2,\n  3,\n  4,\n)",
+        "[\n  1,\n  2,\n  3,\n  4,\n]",
         [1, 2, 3, 4],
       ],
       [
         // associative.
-        "array(\n  'a' => 1,\n)",
+        "[\n  'a' => 1,\n]",
         ['a' => 1],
       ],
       // Bool.
@@ -132,12 +132,12 @@ public static function providerTestExport() {
         '\\',
       ],
       [
-        // Double-quote "
+        // Double-quote ".
         "'\"'",
         "\"",
       ],
       [
-        // Single-quote '
+        // Single-quote '.
         '"\'"',
         "'",
       ],
@@ -149,7 +149,7 @@ public static function providerTestExport() {
       // Object.
       [
         // A stdClass object.
-        '(object) array()',
+        '(object) []',
         new \stdClass(),
       ],
       [