Skip to content
Snippets Groups Projects
Commit ceba2409 authored by catch's avatar catch
Browse files

Issue #3444232 by andypost, smustgrave: [8.4] Fix implicitly nullable type...

Issue #3444232 by andypost, smustgrave: [8.4] Fix implicitly nullable type declarations for phpstan job (manual ones)

(cherry picked from commit 631c33c7)
parent a9d695f7
No related branches found
No related tags found
17 merge requests!12212Issue #3445525 by alexpott, japerry, catch, mglaman, longwave: Add BC layer...,!10602Issue #3438769 by vinmayiswamy, antonnavi, michelle, amateescu: Sub workspace does not clear,!10301Issue #3469309 by mstrelan, smustgrave, moshe weitzman: Use one-time login...,!10187Issue #3487488 by dakwamine: ExtensionMimeTypeGuesser::guessMimeType must support file names with "0" (zero) like foo.0.zip,!9929Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9787Resolve issue 3479427 - bootstrap barrio issue under Windows,!9742Issue #3463908 by catch, quietone: Split OptionsFieldUiTest into two,!9526Issue #3458177 by mondrake, catch, quietone, godotislate, longwave, larowlan,...,!8949Backport .gitlabci.yml changes.,!8738Issue #3424162 by camilledavis, dineshkumarbollu, smustgrave: Claro...,!8704Make greek characters available in ckeditor5,!8533Issue #3446962 by kim.pepper: Remove incorrectly added...,!8517Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false positive,!7445Issue #3440169: When using drupalGet(), provide an associative array for $headers,!6502Draft: Resolve #2938524 "Plach testing issue",!38582585169-10.1.x,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key
Pipeline #177712 passed
Pipeline: drupal

#177756

    Pipeline: drupal

    #177752

      Pipeline: drupal

      #177748

        +6
        ......@@ -108,7 +108,7 @@ class DefaultSelection extends SelectionPluginBase implements ContainerFactoryPl
        * @param \Drupal\Core\Entity\EntityRepositoryInterface $entity_repository
        * The entity repository.
        */
        public function __construct(array $configuration, $plugin_id, $plugin_definition, EntityTypeManagerInterface $entity_type_manager, ModuleHandlerInterface $module_handler, AccountInterface $current_user, EntityFieldManagerInterface $entity_field_manager, EntityTypeBundleInfoInterface $entity_type_bundle_info = NULL, EntityRepositoryInterface $entity_repository) {
        public function __construct(array $configuration, $plugin_id, $plugin_definition, EntityTypeManagerInterface $entity_type_manager, ModuleHandlerInterface $module_handler, AccountInterface $current_user, EntityFieldManagerInterface $entity_field_manager, EntityTypeBundleInfoInterface $entity_type_bundle_info, EntityRepositoryInterface $entity_repository) {
        parent::__construct($configuration, $plugin_id, $plugin_definition);
        $this->entityTypeManager = $entity_type_manager;
        ......
        ......@@ -32,7 +32,7 @@ class TwigNodeTrans extends Node {
        /**
        * {@inheritdoc}
        */
        public function __construct(Node $body, Node $plural = NULL, AbstractExpression $count = NULL, AbstractExpression $options = NULL, $lineno, $tag = NULL) {
        public function __construct(Node $body, ?Node $plural = NULL, ?AbstractExpression $count = NULL, ?AbstractExpression $options = NULL, $lineno = 0, $tag = NULL) {
        $nodes['body'] = $body;
        if ($count !== NULL) {
        $nodes['count'] = $count;
        ......
        ......@@ -244,7 +244,7 @@ public static function providerIsDefaultConfiguration() {
        *
        * @dataProvider providerLoadByEntityTypeBundle
        */
        public function testLoadByEntityTypeBundle($config_id, ContentLanguageSettings $existing_config = NULL, $expected_langcode, $expected_language_alterable) {
        public function testLoadByEntityTypeBundle($config_id, ?ContentLanguageSettings $existing_config, $expected_langcode, $expected_language_alterable) {
        [$type, $bundle] = explode('.', $config_id);
        $nullConfig = new ContentLanguageSettings([
        ......
        ......@@ -56,7 +56,14 @@ class NodeForm extends ContentEntityForm {
        * @param \Drupal\Core\Datetime\DateFormatterInterface $date_formatter
        * The date formatter service.
        */
        public function __construct(EntityRepositoryInterface $entity_repository, PrivateTempStoreFactory $temp_store_factory, EntityTypeBundleInfoInterface $entity_type_bundle_info = NULL, TimeInterface $time = NULL, AccountInterface $current_user, DateFormatterInterface $date_formatter) {
        public function __construct(
        EntityRepositoryInterface $entity_repository,
        PrivateTempStoreFactory $temp_store_factory,
        EntityTypeBundleInfoInterface $entity_type_bundle_info,
        TimeInterface $time,
        AccountInterface $current_user,
        DateFormatterInterface $date_formatter,
        ) {
        parent::__construct($entity_repository, $entity_type_bundle_info, $time);
        $this->tempStoreFactory = $temp_store_factory;
        $this->currentUser = $current_user;
        ......
        ......@@ -71,7 +71,7 @@ public function __construct(
        EntityTypeInterface $entity_type,
        AccountInterface $current_user,
        EntityTypeManagerInterface $entity_type_manager,
        RendererInterface $renderer = NULL,
        RendererInterface $renderer,
        MessengerInterface $messenger,
        ) {
        parent::__construct($entity_type, $entity_type_manager->getStorage($entity_type->id()));
        ......
        ......@@ -61,7 +61,7 @@ protected function setUp(): void {
        * @covers ::getAddPageRoute
        * @dataProvider providerTestGetAddPageRoute
        */
        public function testGetAddPageRoute(Route $expected = NULL, EntityTypeInterface $entity_type) {
        public function testGetAddPageRoute(?Route $expected, EntityTypeInterface $entity_type) {
        $route = $this->routeProvider->getAddPageRoute($entity_type);
        $this->assertEquals($expected, $route);
        }
        ......@@ -99,7 +99,7 @@ public static function providerTestGetAddPageRoute() {
        * @covers ::getAddFormRoute
        * @dataProvider providerTestGetAddFormRoute
        */
        public function testGetAddFormRoute(Route $expected = NULL, EntityTypeInterface $entity_type, EntityTypeInterface $bundle_entity_type = NULL, FieldStorageDefinitionInterface $field_storage_definition = NULL) {
        public function testGetAddFormRoute(?Route $expected, EntityTypeInterface $entity_type, ?EntityTypeInterface $bundle_entity_type = NULL, ?FieldStorageDefinitionInterface $field_storage_definition = NULL) {
        if ($bundle_entity_type) {
        $this->entityTypeManager->getDefinition('the_bundle_entity_type_id')->willReturn($bundle_entity_type);
        ......@@ -200,7 +200,7 @@ public static function providerTestGetAddFormRoute() {
        * @covers ::getCanonicalRoute
        * @dataProvider providerTestGetCanonicalRoute
        */
        public function testGetCanonicalRoute(Route $expected = NULL, EntityTypeInterface $entity_type, FieldStorageDefinitionInterface $field_storage_definition = NULL) {
        public function testGetCanonicalRoute(?Route $expected, EntityTypeInterface $entity_type, ?FieldStorageDefinitionInterface $field_storage_definition = NULL) {
        if ($field_storage_definition) {
        $this->entityFieldManager->getFieldStorageDefinitions($entity_type->id())
        ->willReturn([$entity_type->getKey('id') => $field_storage_definition]);
        ......@@ -260,7 +260,7 @@ public static function providerTestGetCanonicalRoute() {
        * @covers ::getCollectionRoute
        * @dataProvider providerTestGetCollectionRoute
        */
        public function testGetCollectionRoute(Route $expected = NULL, EntityTypeInterface $entity_type) {
        public function testGetCollectionRoute(?Route $expected, EntityTypeInterface $entity_type) {
        $route = $this->routeProvider->getCollectionRoute($entity_type);
        $this->assertEquals($expected, $route);
        }
        ......@@ -379,12 +379,12 @@ public function testGetEntityTypeIdKeyTypeNotFieldable() {
        }
        /**
        * @param \Prophecy\Prophecy\ObjectProphecy $base_entity_type
        * @param \Prophecy\Prophecy\ObjectProphecy|null $base_entity_type
        * (optional) The prophesize base entity type.
        *
        * @return \Prophecy\Prophecy\ObjectProphecy
        */
        protected static function getEntityType(ObjectProphecy $base_entity_type = NULL) {
        protected static function getEntityType(?ObjectProphecy $base_entity_type = NULL) {
        $entity_type = (new Prophet())->prophesize(EntityTypeInterface::class);
        if ($base_entity_type) {
        foreach ($base_entity_type->getMethodProphecies() as $method => $prophecies) {
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Please register or to comment