Skip to content
Snippets Groups Projects

Issue #3472946 by xmacinfo, dpi: Clarify “Database support for JSON” success...

Closed Issue #3472946 by xmacinfo, dpi: Clarify “Database support for JSON” success...
issue/drupal-3472946:3472946-clarify-database-support into 11.x
1 unresolved thread
Closed Jacques R. Blier requested to merge issue/drupal-3472946:3472946-clarify-database-support into 11.x
1 unresolved thread

Issue #3472946 by xmacinfo, dpi: Clarify “Database support for JSON” success requirement message for Drupal 11

Closes #3472946

Merge request reports

Merge request pipeline #347595 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3472946

#347596

    Merge request pipeline passed for fef04b40

    Approval is optional
    Code Quality is loading
    Test summary results are being parsed
    Full report
    Merge blocked: 1 check failed
    Merge conflicts must be resolved.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/modules/system/tests/src/Functional/System/StatusTest.php
    117 117 // Check if JSON database support is enabled.
    118 118 $this->assertSession()->pageTextContains('Database support for JSON');
    119 119 $elements = $this->xpath('//details[@class="system-status-report__entry"]//div[contains(text(), :text)]', [
    120 ':text' => 'Is required in Drupal 10.0.',
    120 ':text' => 'Drupal requires databases that support JSON.',
    • daffie
      daffie @daffie
      Developer

      I could like to change the text to: "Drupal requires databases that support JSON storage." Most databases have now support for JSON storage. The amount of functionality differs across databases. PostgreSQL is the leader in that field at the moment. With adding the "storage" bit, we can later as needed at checks on the amount of JSON functionality that the database offers.

    • Jacques R. Blier changed this line in version 3 of the diff

      changed this line in version 3 of the diff

    • Please register or sign in to reply
  • Jacques R. Blier added 1 commit

    added 1 commit

    • fef04b40 - Update the JSON requirement text and related test

    Compare with previous version

  • Dave Long closed

    closed

    • Please register or sign in to reply