Skip to content
Snippets Groups Projects

fixes

Open fixes
issue/drupal-3484224:3484224-remove-return-and into 11.x
1 unresolved thread
Open quietone requested to merge issue/drupal-3484224:3484224-remove-return-and into 11.x
1 unresolved thread

Closes #3484224

Merge request reports

Members who can merge are allowed to add commits.

Merged results pipeline #345490 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#345496

    Merged results pipeline passed for 95e6b110

    Approval is optional
    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.

    Merge details

    • The source branch is 882 commits behind the target branch.
    • 1 commit and 1 merge commit will be added to .
    • Source branch will not be deleted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/lib/Drupal/Core/Action/ActionPluginCollection.php
    11 11
    12 12 /**
    13 13 * {@inheritdoc}
    14 *
    15 * @return \Drupal\Core\Action\ActionInterface
    • Comment on lines -14 to -15
      Michael Strelan
      Michael Strelan @mstrelan

      This is giving us less specific type info than we have before, which makes static analysis difficult. I would be in favour of removing this annotation and adding a native return type, but we'd need to be careful with BC. A trick we use internally is to use @phpstan-return to annotate the return type while not requiring a comment, but I don't think that's a pattern used in core (yet).

    • Joris Vercammen
      Joris Vercammen @borisson_

      It's not a pattern we use already no, it is also not allowed to mix inheritdoc with anything else as far as I know. Do we need to copy over the comment from the parent instead?

      This is something we need to consider for all the other places where we're doing this.

    • Please register or sign in to reply
  • quietone added 43 commits

    added 43 commits

    Compare with previous version

  • quietone added 46 commits

    added 46 commits

    Compare with previous version

    • Please register or sign in to reply