Skip to content
Snippets Groups Projects

Issue #3482035: refactor default severity in preRenderGroupRequirements()

Open Issue #3482035: refactor default severity in preRenderGroupRequirements()
issue/drupal-3482035:3482035-refactor-default-severity into 11.x
2 unresolved threads
Open Sourav Paul requested to merge issue/drupal-3482035:3482035-refactor-default-severity into 11.x
2 unresolved threads

Closes #3482035

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/lib/Drupal/Core/Render/Element/StatusReport.php
41 41 $requirement_severity = (int) $requirement['severity'] === REQUIREMENT_OK ? REQUIREMENT_INFO : (int) $requirement['severity'];
42 42 $severity = $severities[$requirement_severity];
43 43 }
44 elseif (defined('MAINTENANCE_MODE') && MAINTENANCE_MODE == 'install') {
45 $severity = $severities[REQUIREMENT_OK];
44 else {
45 $severity = (defined('MAINTENANCE_MODE') && MAINTENANCE_MODE == 'install') ? $severities[REQUIREMENT_OK] : $severities[REQUIREMENT_INFO];
  • Joachim Noreiko
    Joachim Noreiko @joachim

    If we're covering all cases then the initial

      $severity = $severities[REQUIREMENT_INFO];

    should be removed.

  • Sourav Paul added 1 commit

    added 1 commit

    Compare with previous version

  • Sourav Paul added 1 commit

    added 1 commit

    Compare with previous version

  • Stephen Mustgrave
    Stephen Mustgrave @smustgrave started a thread on the diff
    • core/lib/Drupal/Core/Render/Element/StatusReport.php
    36 36 $severities = static::getSeverities();
    37 37 $grouped_requirements = [];
    38 38 foreach ($element['#requirements'] as $key => $requirement) {
    39 $severity = $severities[REQUIREMENT_INFO];
    40 39 if (isset($requirement['severity'])) {
    41 40 $requirement_severity = (int) $requirement['severity'] === REQUIREMENT_OK ? REQUIREMENT_INFO : (int) $requirement['severity'];
    42 41 $severity = $severities[$requirement_severity];
    43 42 }
    44 elseif (defined('MAINTENANCE_MODE') && MAINTENANCE_MODE == 'install') {
    45 $severity = $severities[REQUIREMENT_OK];
    43 else {
    Please register or sign in to reply