Skip to content
Snippets Groups Projects

Follow symlinks properly

Closed nicxvan requested to merge issue/drupal-3482283:3482283-symlinking-a-module into 11.x
1 unresolved thread

Closes #3482283

Merge request reports

Approval is optional
Code Quality is loading
Test summary results are being parsed

Closed by catchcatch 6 months ago (Oct 22, 2024 12:20pm UTC)

Merge details

  • The changes were not merged into 11.x.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • nicxvan added 1 commit

    added 1 commit

    Compare with previous version

  • nicxvan added 1 commit

    added 1 commit

    Compare with previous version

  • nicxvan added 1 commit

    added 1 commit

    Compare with previous version

  • nicxvan added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Cooper
  • Ted Cooper
  • nicxvan added 1 commit

    added 1 commit

    Compare with previous version

  • nicxvan added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Rowlands resolved all threads

    resolved all threads

  • 16
    17 /**
    18 * VFS does not and can not support symlinks.
    19 */
    20 protected function setUpFilesystem(): void {}
    21
    22 /**
    23 * Test that symlinks are properly followed.
    24 */
    25 public function testSymlink(): void {
    26 mkdir($this->siteDirectory);
    27
    28 foreach (scandir("core/modules/user/tests/modules/user_hooks_test") as $item) {
    29 $target = "$this->siteDirectory/$item";
    30 if (!file_exists($target)) {
    31 symlink(realpath("core/modules/user/tests/modules/user_hooks_test/$item"), $target);
  • Were we expecting the test-only job to fail here? https://git.drupalcode.org/issue/drupal-3482283/-/jobs/3116042 - it appears that it did not

  • Alex Pott added 1 commit

    added 1 commit

    • a880b66b - Ensure the test fails if symlinks are not followed

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 4 commits

    added 4 commits

    Compare with previous version

  • Alex Pott added 11 commits

    added 11 commits

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading