Skip to content
Snippets Groups Projects

2838547: Remove default colon behind inline labels.

1 unresolved thread

Closes #2838547

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 2c555c3c - 2838547: Make inline label translatable.

    Compare with previous version

  • Nayana Ramakrishnan resolved all threads

    resolved all threads

  • 1408 1408 // readers.
    1409 1409 $variables['label'] = $element['#title'];
    1410 1410
    1411 // Append translatable ':' after label if inline label
    1412 // display is selected.
    1413 if ($variables['label_display'] == 'inline') {
    1414 $variables['label'] = t('@label_inline:', ['@label_inline' => $variables['label']]);
    • need a string context, we can use "Field label"

      Edited by Théodore Biadala
    • Do we really need context here? I would have thought the @variable name should give the context.

      Suggested change
      1434 $variables['label'] = t('@label_inline:', ['@label_inline' => $variables['label']]);
      1434 $variables['label'] = t('@field_label_inline:', ['@field_label_inline' => $variables['label']]);

      Would add as much context without using the translation context system.

    • Please register or sign in to reply
    Please register or sign in to reply
    Loading