Skip to content
Snippets Groups Projects

2838547: Remove default colon behind inline labels.

Open 2838547: Remove default colon behind inline labels.
issue/drupal-2838547:2838547-remove-default-colon into 11.x
1 unresolved thread
Open Nayana Ramakrishnan requested to merge issue/drupal-2838547:2838547-remove-default-colon into 11.x
1 unresolved thread

Closes #2838547

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #319220 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-2838547

#319227

    Merge request pipeline passed for 2c555c3c

    Approval is optional
    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.
    • The source branch is 1070 commits behind the target branch.
    • 1 commit will be added to 11.x.
    • Source branch will not be deleted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Nayana Ramakrishnan added 1 commit

    added 1 commit

    • 2c555c3c - 2838547: Make inline label translatable.

    Compare with previous version

  • Nayana Ramakrishnan resolved all threads

    resolved all threads

  • Théodore Biadala
    Théodore Biadala @nod_ started a thread on the diff
    • core/includes/theme.inc
    1408 1408 // readers.
    1409 1409 $variables['label'] = $element['#title'];
    1410 1410
    1411 // Append translatable ':' after label if inline label
    1412 // display is selected.
    1413 if ($variables['label_display'] == 'inline') {
    1414 $variables['label'] = t('@label_inline:', ['@label_inline' => $variables['label']]);
    • Théodore Biadala
      Théodore Biadala @nod_
      Maintainer

      need a string context, we can use "Field label"

      Edited by Théodore Biadala
    • A
      Alex Pott @alexpott
      Maintainer

      Do we really need context here? I would have thought the @variable name should give the context.

      Suggested change
      1434 $variables['label'] = t('@label_inline:', ['@label_inline' => $variables['label']]);
      1434 $variables['label'] = t('@field_label_inline:', ['@field_label_inline' => $variables['label']]);

      Would add as much context without using the translation context system.

    • Please register or sign in to reply
    Please register or sign in to reply