Skip to content
Snippets Groups Projects

created mr based on last patch and fix linting issues

Open created mr based on last patch and fix linting issues
issue/drupal-2949573:2949573-call-to-a into 11.x
2 unresolved threads
Open Rajneesh Babu requested to merge issue/drupal-2949573:2949573-call-to-a into 11.x
2 unresolved threads

Closes #2949573

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #297024 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-2949573

#297026

    Merge request pipeline passed for 1082f3d6

    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.
    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/modules/image/src/Plugin/Field/FieldFormatter/ImageFormatter.php
    249 $message = $this->t('The image style of %field field is broken on the %entity bundle %bundle.%extraNodeMessage', [
    250 '%field' => $fieldDefinitionForMessage->getName(),
    251 '%entity' => $fieldDefinitionForMessage->getTargetEntityTypeId(),
    252 '%bundle' => $fieldDefinitionForMessage->getTargetBundle(),
    253 '%extraNodeMessage' => $fieldDefinitionForMessage->getTargetEntityTypeId() == 'node'
    254 ? "\nTry (re)setting the image style in the display settings and form display settings."
    255 : '',
    256 ]);
    257 \Drupal::messenger()->addError($message);
    258 return [
    259 '#type' => 'markup',
    260 '#markup' => '<pre>' . $message . '</pre>',
    261 '#cache' => [
    262 'max-age' => 0,
    263 ],
    264 ];
  • Julian Pustkuchen
    Julian Pustkuchen @Anybody started a thread on the diff
    • core/modules/image/src/Plugin/Field/FieldFormatter/ImageFormatter.php
    240 243 $image_style = $this->imageStyleStorage->load($image_style_setting);
    241 $base_cache_tags = $image_style->getCacheTags();
    244 if (!empty($image_style)) {
    245 $base_cache_tags = $image_style->getCacheTags();
    246 }
    247 else {
    248 $fieldDefinitionForMessage = $items->getFieldDefinition();
    249 $message = $this->t('The image style of %field field is broken on the %entity bundle %bundle.%extraNodeMessage', [
    250 '%field' => $fieldDefinitionForMessage->getName(),
    251 '%entity' => $fieldDefinitionForMessage->getTargetEntityTypeId(),
    252 '%bundle' => $fieldDefinitionForMessage->getTargetBundle(),
    253 '%extraNodeMessage' => $fieldDefinitionForMessage->getTargetEntityTypeId() == 'node'
    254 ? "\nTry (re)setting the image style in the display settings and form display settings."
    255 : '',
    256 ]);
    257 \Drupal::messenger()->addError($message);
    Please register or sign in to reply