Skip to content
Snippets Groups Projects

Start taxonomy term admin list page performance test

Closes #3476439

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
44
45 /**
46 * Logs vocabulary admin page tracing data with a hot cache.
47 *
48 * Hot here means that all possible caches are warmed.
49 */
50 protected function testHotCache(): void {
51 // Request the page twice so that asset aggregates are definitely cached in
52 // the browser cache.
53 $this->drupalGet('admin/structure/taxonomy/manage/tags/overview');
54 $this->drupalGet('admin/structure/taxonomy/manage/tags/overview');
55
56 $performance_data = $this->collectPerformanceData(function () {
57 $this->drupalGet('admin/structure/taxonomy/manage/tags/overview');
58 }, 'umamiVocabularyAdminPageHotCache');
59 $this->assertSession()->pageTextContains('Baked');
  • Comment on lines +56 to +59

    It looks like we are not logged in when doing the request. This is probably measuring the 403 page right now. Not sure why the word "Baked" appears in there.

    Maybe we can check that the actual term overview is visible on the page? E.g. by checking the if the element with XPath //table[@id="taxonomy"] is present?

  • It looks like we are not logged in when doing the request. This is probably measuring the 403 page right now. Not sure why the word "Baked" appears in there.

    You are totally right :thumbsup:

    umami is listing terms on every page, that is why it was passing.

    I'll change this, and also add some extra coverage.

  • Marco Villegas changed this line in version 5 of the diff

    changed this line in version 5 of the diff

  • Please register or sign in to reply
  • added 1 commit

    • 9ad0e4e8 - Actually look for things at the right place :sweat_smile:

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Marco Villegas added 2 commits

    added 2 commits

    • 709d5b6f - Do not use the umami block with tags vocabulary terms as a block in the footer
    • 725432dc - Unify the approach to match the term

    Compare with previous version

  • Marco Villegas added 3 commits

    added 3 commits

    • 19f8eb2d - Unify the approach to match the term
    • a357447a - Add cache bins clear to PerformanceTestTrait
    • 06c218fe - Add a cool cache case for vocabulary admin performance test

    Compare with previous version

  • added 1 commit

    • 2aef88e1 - Add a cool cache case for vocabulary admin performance test

    Compare with previous version

  • Vinai Katiyar added 1 commit

    added 1 commit

    Compare with previous version

  • shalini jha added 168 commits

    added 168 commits

    • 82584851...1afb8711 - 159 commits from branch project:11.x
    • 4eb53daf - Start taxonomy term admin list page performance test
    • 47253f41 - Remove unused use statement
    • c9ea8aa8 - Actually look for things at the right place :sweat_smile:
    • 19e42ab7 - Make linter happy
    • 67ba173e - Do not use the umami block with tags vocabulary terms as a block in the footer
    • 8b4de15d - Unify the approach to match the term
    • caa8b2db - Add cache bins clear to PerformanceTestTrait
    • 6bc2b331 - Add a cool cache case for vocabulary admin performance test
    • 90224250 - Resolved PHPStan errors

    Compare with previous version

  • shalini jha added 133 commits

    added 133 commits

    • 90224250...69dc12e1 - 123 commits from branch project:11.x
    • e12565b8 - Start taxonomy term admin list page performance test
    • f33737b5 - Remove unused use statement
    • 77fcefd8 - Actually look for things at the right place :sweat_smile:
    • 8d3e898c - Make linter happy
    • 99675d72 - Do not use the umami block with tags vocabulary terms as a block in the footer
    • 9f5a724c - Unify the approach to match the term
    • edbdde02 - Add cache bins clear to PerformanceTestTrait
    • d52475e0 - Add a cool cache case for vocabulary admin performance test
    • 7ccf71e8 - Resolved PHPStan errors
    • d231d49f - Issue #3476439: Update cache count to fix pipeline failure

    Compare with previous version

  • shalini jha added 209 commits

    added 209 commits

    • d231d49f...0be56730 - 199 commits from branch project:11.x
    • 4610ba3c - Start taxonomy term admin list page performance test
    • 9832c11c - Remove unused use statement
    • b1115f00 - Actually look for things at the right place :sweat_smile:
    • 3e123a7a - Make linter happy
    • 617e15c7 - Do not use the umami block with tags vocabulary terms as a block in the footer
    • 7a01b0d1 - Unify the approach to match the term
    • 130facaa - Add cache bins clear to PerformanceTestTrait
    • d1f85749 - Add a cool cache case for vocabulary admin performance test
    • 5aaf9c82 - Resolved PHPStan errors
    • 2aceabd7 - Issue #3476439: Update cache count to fix pipeline failure

    Compare with previous version

  • shalini jha added 15 commits

    added 15 commits

    • 2aceabd7...54c4637e - 5 commits from branch project:11.x
    • 1470cf19 - Start taxonomy term admin list page performance test
    • c8680374 - Remove unused use statement
    • 8d0fc7a0 - Actually look for things at the right place :sweat_smile:
    • 5b26390d - Make linter happy
    • d1aa77e5 - Do not use the umami block with tags vocabulary terms as a block in the footer
    • eb115d6d - Unify the approach to match the term
    • e9d5100a - Add cache bins clear to PerformanceTestTrait
    • c635090b - Add a cool cache case for vocabulary admin performance test
    • 998a4fcf - Resolved PHPStan errors
    • be4dec99 - Issue #3476439: Update cache count to fix pipeline failure

    Compare with previous version

  • shalini jha added 1 commit

    added 1 commit

    • c752ea55 - Addressed feedback for assertMetrics

    Compare with previous version

  • 681 682 ];
    682 683 }
    683 684
    685 /**
  • shalini jha added 77 commits

    added 77 commits

    • c752ea55...d1a4f6e0 - 66 commits from branch project:11.x
    • 6c6c8923 - 1 earlier commit
    • 8751a972 - Remove unused use statement
    • f48be8f4 - Actually look for things at the right place :sweat_smile:
    • 29ca94f6 - Make linter happy
    • 402341a6 - Do not use the umami block with tags vocabulary terms as a block in the footer
    • cac28a6d - Unify the approach to match the term
    • 3ded9968 - Add cache bins clear to PerformanceTestTrait
    • 38d0fc63 - Add a cool cache case for vocabulary admin performance test
    • a0d463e3 - Resolved PHPStan errors
    • 2f2fcbd5 - Issue #3476439: Update cache count to fix pipeline failure
    • 40d9c08c - Addressed feedback for assertMetrics

    Compare with previous version

  • shalini jha added 41 commits

    added 41 commits

    • 40d9c08c...f5a836d5 - 29 commits from branch project:11.x
    • f5a836d5...0ffca9de - 2 earlier commits
    • 7abb7e2b - Actually look for things at the right place :sweat_smile:
    • e890a010 - Make linter happy
    • 05cc9e2f - Do not use the umami block with tags vocabulary terms as a block in the footer
    • ae849e1a - Unify the approach to match the term
    • 255575ea - Add cache bins clear to PerformanceTestTrait
    • b19b43b2 - Add a cool cache case for vocabulary admin performance test
    • d7d00086 - Resolved PHPStan errors
    • 285853c4 - Issue #3476439: Update cache count to fix pipeline failure
    • 83f4ec13 - Addressed feedback for assertMetrics
    • beac7274 - Removed clearCaches method.

    Compare with previous version

  • shalini jha added 1 commit

    added 1 commit

    Compare with previous version

  • shalini jha added 1 commit

    added 1 commit

    Compare with previous version

  • shalini jha added 1 commit

    added 1 commit

    • 279cbfad - Edit VocabularyAdminPerformanceTest.php

    Compare with previous version

  • catch @catch started a thread on the diff
  • 1 <?php
    2
    3 declare(strict_types=1);
    4
    5 namespace Drupal\Tests\demo_umami\FunctionalJavascript;
    6
    7 use Drupal\block\Entity\Block;
    8 use Drupal\Core\Cache\Cache;
    9 use Drupal\FunctionalJavascriptTests\PerformanceTestBase;
    10
    11 /**
    12 * Tests demo_umami profile performance on vocabulary admin page.
    13 *
    14 * @group OpenTelemetry
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading