Skip to content
Snippets Groups Projects

Apply comment suggestion

Open Apply comment suggestion
issue/drupal-3384600:3384600-10.4 into 10.4.x
1 unresolved thread
Open Benji Fisher requested to merge issue/drupal-3384600:3384600-10.4 into 10.4.x
1 unresolved thread

Co-authored by: @benjifisher

Closes #3384600

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/user/src/Entity/EntityPermissionsRouteProvider.php
13 13 /**
14 14 * Provides routes for the entity permissions form.
15 15 *
16 * Use this class or EntityPermissionsRouteProviderWithCheck as a route
17 * provider for an entity type such as Vocabulary. Either one will provide
18 * routes for the entity permissions form. The
19 * EntityPermissionsRouteProviderWithCheck class provides a custom access check:
20 * it denies access if there are no entity-specific permissions. If you know
21 * that each entity has permissions, or if the check is too expensive, then use
22 * this class.
16 * Use this class as a route provider for an entity type such as Vocabulary. It
17 * will provide routes for the entity permissions form.
  • Sascha Grossenbacher
    Sascha Grossenbacher @berdir ·
    Developer

    this is not what the description said before. It said the other one should be used for vocabulary. Not sure if that's also in 11.x now.

    The second sentence repeats the first on top, so I think this paragraph can be dropped completely.

  • Benji Fisher
    Benji Fisher @benjifisher ·
    Author Developer

    Since we are deprecating EntityPermissionsRouteProviderWithCheck, it makes sense now to recommend this class for vocabularies.

    I agree that we can remove the second sentence.

  • Sascha Grossenbacher
    Sascha Grossenbacher @berdir ·
    Developer

    There is only one permission route provider that you can use for all entity types. We don't need to specifically point out Vocabulary, that's just confusing.

    The previous explanation why the other class should be used for Vocabulary and not this has already been removed.

  • Please register or sign in to reply
Please register or sign in to reply