Fix "call to undefined' PHPStan-0 issues in migration system
Closes #3469836
Merge request reports
Activity
added 79 commits
-
a13223e7...9258113b - 78 commits from branch
project:11.x
- a08983c6 - fixes
-
a13223e7...9258113b - 78 commits from branch
- Resolved by Stephen Mustgrave
32 32 ]; 33 33 } 34 34 35 /** 36 * Install required entity schemas. 37 */ 38 protected function installEntitySchemas() { And yet, migration tests are full of duplication in the d6/d7 versions of some test. The effort to make a base class or other solution for the same code in the Kernel migration tests out weighed the benefit. And I would argue the same applied here, but sort of in reverse. When this was added there was other 'duplications' in the D6/D7 versions of the Audit tests but for whatever reason they were not pulled out into a shared method.
I think it is OK to duplicate.
342 342 return NULL; 343 343 } 344 344 345 /** 346 * Checks public and private files are copied but not temporary files. 347 */ 348 protected function assertFileMigrations() { changed this line in version 3 of the diff
Hmm, I forgot to leave a note about this. In general, contrib does not write functional tests for migration. And at the time I checked and the only used was in commerce_migrate. Today, this search shows that still be true. And I will make any changes in commerce_migrate for this.
However, this now has a difference solution which is to add a method
getManagedFiles
to the base class. That seems a bit simpler.
added 40 commits
-
a08983c6...16c1f490 - 36 commits from branch
project:11.x
- c1a81e06 - fixes
- deeb1022 - MigrateDumpAlter
- fae25d1c - installEntitySchemas
- ec08defb - managedFiles
Toggle commit list-
a08983c6...16c1f490 - 36 commits from branch
added 42 commits
-
ec08defb...2fddf325 - 41 commits from branch
project:11.x
- b1d755a1 - Merge remote-tracking branch 'origin/11.x' into drupal-3469836-3469836--fix-call
-
ec08defb...2fddf325 - 41 commits from branch
- Resolved by Stephen Mustgrave
- Resolved by Stephen Mustgrave
- Resolved by Lucas Hedding
added 1 commit
added 405 commits
-
58e4880c...a0503e22 - 397 commits from branch
project:11.x
- 0b712fe5 - fixes
- 9b880ee7 - MigrateDumpAlter
- 557d1b36 - installEntitySchemas
- d0feac63 - managedFiles
- a2ee957e - Apply 1 suggestion(s) to 1 file(s)
- 154901cd - Apply 1 suggestion(s) to 1 file(s)
- ada5c221 - Issue #3469836: Updated function doc as suggested
- e761191c - rebuild baseline
Toggle commit list-
58e4880c...a0503e22 - 397 commits from branch
added 6 commits
-
faadf8a0...8bc7475d - 5 commits from branch
project:11.x
- d57deaae - Merge branch drupal:11.x into 3469836--fix-call
-
faadf8a0...8bc7475d - 5 commits from branch
175 175 $this->migration = $migration; 176 176 } 177 177 if ($this instanceof MigrateDumpAlterInterface) { 178 static::migrateDumpAlter($this); 178 $this::migrateDumpAlter($this); changed this line in version 12 of the diff
added 17 commits
-
d57deaae...798ad9e4 - 7 commits from branch
project:11.x
- 90e6fd0c - fixes
- eaab5d03 - MigrateDumpAlter
- 783576c8 - installEntitySchemas
- ae4cac04 - managedFiles
- 3f086bc2 - Apply 1 suggestion(s) to 1 file(s)
- 53f11607 - Apply 1 suggestion(s) to 1 file(s)
- 07d1642a - Issue #3469836: Updated function doc as suggested
- 0d03a1a3 - rebuild baseline
- fb6ad6d3 - Update FilePathTest.php
- d87fd61b - suggestion
Toggle commit list-
d57deaae...798ad9e4 - 7 commits from branch