Resolve #3466503 "Fix some spelling"
2 unresolved threads
Closes #3466503
Merge request reports
Activity
168 168 ]; 169 169 $account = $this->drupalCreateUser($permissions); 170 170 $this->drupalLogin($account); 171 $webassert = $this->assertSession(); -
It is more common for tests to use $assert_session here. Maybe these instances should change?
Edited by quietone
10 10 * @prop {Drupal~behaviorAttach} attach 11 11 * Makes changes in the DOM to be able to test the completion of AJAX in assertWaitOnAjaxRequest. 12 12 */ 13 Drupal.behaviors.js_webassert_test_wait_for_ajax_request = { 13 Drupal.behaviors.js_web_assert_test_wait_for_ajax_request = { -
@quietone this (and beyond) is where I meant. Maybe it's fine, but I think before it was clear that this is about WebAssert whereas now I'm not sure if it's about that or something else.
But now I see it's actually about JsWebAssert, and it's already prefixed with js_, so now I don't know what to think.
changed this line in version 2 of the diff
added 31 commits
-
6728f699...b6c3c60a - 19 commits from branch
project:11.x - b6c3c60a...da276a96 - 2 earlier commits
- 289863e0 - sameline
- add8ea0a - samename
- 127e2a6a - specialchars
- a1be2b0a - renderered
- 993c85a8 - notexisting
- 6ef96031 - userref
- 665dccac - permissionless
- 75ced3b8 - part of isinstallable
- a4997d19 - Revert "webassert"
- d4fd765c - allow jswebassert
Toggle commit list-
6728f699...b6c3c60a - 19 commits from branch
added 49 commits
-
d4fd765c...020d5fb7 - 37 commits from branch
project:11.x - 020d5fb7...d8e1e398 - 2 earlier commits
- 0b1d418e - sameline
- b22775ba - samename
- 412c3ec5 - specialchars
- f36d7a23 - renderered
- c6be33d5 - notexisting
- c951065b - userref
- 21c3c19a - permissionless
- c4a9e3d5 - part of isinstallable
- c4f739d9 - Revert "webassert"
- 62cb6ca7 - allow jswebassert
Toggle commit list-
d4fd765c...020d5fb7 - 37 commits from branch
Please register or sign in to reply