Skip to content
Snippets Groups Projects

Closes #3464213

Closed Closes #3464213
issue/drupal-3464213:3464213-method-getmockforabstractclass-of into 11.x
1 unresolved thread
Closed mondrake requested to merge issue/drupal-3464213:3464213-method-getmockforabstractclass-of into 11.x
1 unresolved thread

Closes #3464213

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/tests/Drupal/Tests/Component/Plugin/StubPluginBase.php 0 → 100644
1 <?php
2
3 declare(strict_types=1);
4
5 namespace Drupal\Tests\Component\Plugin;
6
7 use Drupal\Component\Plugin\PluginBase;
8
9 /**
10 * A class extending PluginBase for testing purposes.
11 */
12 class StubPluginBase extends PluginBase {
  • C
    catch @catch ·
    Maintainer

    If this is only used in the one class, why not define the class directly in the test file itself? We've done that in some other unit tests.

  • M
    mondrake @mondrake ·
    Author Contributor

    I have seen multiple classes/namespaces in the same file having problems with Rector, see for instance here https://www.drupal.org/project/drupal/issues/3446693 where rector could not write 'use' imports, FQCN are written instead, and we'll be having to manage that manually.

    So if it's not a big problem I'd rather go for a separate file, which also is more gentle to autoloading and visibility.

  • Please register or sign in to reply
  • catch closed

    closed

    • Please register or sign in to reply