Skip to content
Snippets Groups Projects

Enables navigation module for umami

Open Mark Conroy requested to merge issue/drupal-3421869:3421869-grant-author-and into 11.x
4 unresolved threads

Closes #3421869

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Conroy added 1 commit

    added 1 commit

    • 5dd1ffdf - don't install toolbar module.

    Compare with previous version

  • Mark Conroy resolved all threads

    resolved all threads

  • Mark Conroy added 1 commit

    added 1 commit

    • 0f9863d1 - removes toolbar-related permissions

    Compare with previous version

  • Mark Conroy added 1 commit

    added 1 commit

    • a6391294 - removes toolbar permission from test, since toolbar will not be used any more

    Compare with previous version

  • Mark Conroy added 1 commit

    added 1 commit

    Compare with previous version

  • Mark Conroy added 65 commits

    added 65 commits

    Compare with previous version

  • Pooja Sharma added 1 commit

    added 1 commit

    • 94b8fd84 - issue/3421869: Updated DemoUmamiProfileTest

    Compare with previous version

  • 224 223 // Check when editing a node, the warning is visible.
    225 224 $this->drupalGet($recipe_node->toUrl('edit-form'));
    226 225 $web_assert->statusCodeEquals(200);
    227 $web_assert->pageTextContains('This site is intended for demonstration purposes.');
  • Pooja Sharma added 1 commit

    added 1 commit

    • 83dc01c3 - issue/3421869: disable navigation & enable toolbar module DemoUmamiProfileTest.

    Compare with previous version

  • Pooja Sharma added 1 commit

    added 1 commit

    • 7a70ebf4 - issue/3421869: fixed typo error DemoUmamiProfileTest.

    Compare with previous version

  • Mark Conroy added 3 commits

    added 3 commits

    • a7a01841 - Revert "issue/3421869: fixed typo error DemoUmamiProfileTest."
    • 81ebe5d9 - Revert "issue/3421869: disable navigation & enable toolbar module DemoUmamiProfileTest."
    • 2d95978b - Revert "issue/3421869: Updated DemoUmamiProfileTest"

    Compare with previous version

  • Mark Conroy added 10 commits

    added 10 commits

    Compare with previous version

  • Mark Conroy added 1 commit

    added 1 commit

    • 82ca63fc - moves demo profile warning from toolbar to page_top

    Compare with previous version

  • Mark Conroy added 1 commit

    added 1 commit

    Compare with previous version

  • kiwimind
  • 75 function demo_umami_toolbar() {
    76 // Add a warning about using an experimental profile.
    77 // @todo This can be removed once a generic warning for experimental profiles
    78 // has been introduced. https://www.drupal.org/project/drupal/issues/2934374
    79 $items['experimental-profile-warning'] = [
    80 '#weight' => 3400,
    81 '#cache' => [
    82 'contexts' => ['route'],
    83 ],
    84 ];
    85
    86 // Show warning only on administration pages.
    75 function demo_umami_preprocess_html(&$variables) {
    76 // We want to make sure people know that Umami is only a demonstration of
    77 // Drupal, and should not be used as a starterkit.
    78 // To do so, we will show warning at the top of administration pages.
    • Suggested change
      78 // To do so, we will show warning at the top of administration pages.
      78 // To do so, we will show a warning at the top of administration pages.
    • Please register or sign in to reply
  • kiwimind
  • 81 '#cache' => [
    82 'contexts' => ['route'],
    83 ],
    84 ];
    85
    86 // Show warning only on administration pages.
    75 function demo_umami_preprocess_html(&$variables) {
    76 // We want to make sure people know that Umami is only a demonstration of
    77 // Drupal, and should not be used as a starterkit.
    78 // To do so, we will show warning at the top of administration pages.
    87 79 $admin_context = \Drupal::service('router.admin_context');
    88 80 if ($admin_context->isAdminRoute()) {
    89 81 $link_to_help_page = \Drupal::moduleHandler()->moduleExists('help') && \Drupal::currentUser()->hasPermission('access help pages');
    90 $items['experimental-profile-warning']['#type'] = 'toolbar_item';
    91 $items['experimental-profile-warning']['tab'] = [
    82 // Add this to the end of the page
  • kiwimind
  • 85
    86 // Show warning only on administration pages.
    75 function demo_umami_preprocess_html(&$variables) {
    76 // We want to make sure people know that Umami is only a demonstration of
    77 // Drupal, and should not be used as a starterkit.
    78 // To do so, we will show warning at the top of administration pages.
    87 79 $admin_context = \Drupal::service('router.admin_context');
    88 80 if ($admin_context->isAdminRoute()) {
    89 81 $link_to_help_page = \Drupal::moduleHandler()->moduleExists('help') && \Drupal::currentUser()->hasPermission('access help pages');
    90 $items['experimental-profile-warning']['#type'] = 'toolbar_item';
    91 $items['experimental-profile-warning']['tab'] = [
    82 // Add this to the end of the page
    83 $variables['page_top'][] = [
    92 84 '#type' => 'inline_template',
    93 '#template' => '<a class="toolbar-warning" href="{{ more_info_link }}">This site is intended for demonstration purposes.</a>',
    85 '#template' => '<p class="demo-profile-warning"><a href="{{ more_info_link }}">This site is intended for demonstration purposes.</a></p>',
  • Few little things I noticed.

  • Please register or sign in to reply
    Loading