Skip to content
Snippets Groups Projects

Draft: Resolve #3100083 "Web components"

Open Draft: Resolve #3100083 "Web components"
issue/drupal-3100083:3100083-web-components into 11.x
3 unresolved threads
Open Ivan Berdinsky requested to merge issue/drupal-3100083:3100083-web-components into 11.x
3 unresolved threads

Closes #3100083

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/profiles/demo_umami/themes/umami/umami.info.yml
6 6 libraries:
7 7 - umami/classy.base
8 8 - core/normalize
9 - core/drupal.message
  • Mark Conroy
    Mark Conroy @MarkConroy started a thread on the diff
    • core/profiles/demo_umami/themes/umami/templates/components/messages/status-messages.html.twig
    46 <span class="messages__item">{{ messages|first }}</span>
    47 {% endif %}
    48 {% if type == 'error' %}
    49 </div>
    50 {% endif %}
    51 </div>
    23 <div class="messages__wrapper container">
    24 {% block messages %}
    25 {% for type, messages in message_list %}
    26 {%
    27 set classes = [
    28 'messages',
    29 'messages--' ~ type,
    30 ]
    31 %}
    32 <umami-messages-component aria-label="{{ status_headings[type] }}" {{ attributes.addClass(classes)|without('aria-label') }} role={{ type == 'error' or type == 'warning' ? 'alert' : 'status' }}>
  • Mark Conroy
    Mark Conroy @MarkConroy started a thread on the diff
    • core/profiles/demo_umami/themes/umami/js/components/messages/messages.js
    34 48 messageWrapper.setAttribute('data-drupal-message-type', type);
    35 49
    36 50 messageWrapper.innerHTML = `
    37 <div class="messages__content container">
    38 <h2 class="visually-hidden">
    • Mark Conroy
      Mark Conroy @MarkConroy
      Developer

      If we remove this h2 then we won't have a title.

      I'd suggest instead of removing it, we change it to <h2 class="visually-hidden" slot="title">

      And then in the <template> we render <h2 slot="title">{{ status_headings[type] }}</h2>

    • Please register or sign in to reply
    Please register or sign in to reply