Add test with broken property type.

Closes #3462156

added 1 commit

• 5bbf14d1 - Fix PHPCS issues.

Compare with previous version

added 1 commit

• a6e83360 - Remove typo

Compare with previous version

added 1 commit

• 35595b32 - Throw an exception if property type contains non-string value.

Compare with previous version

added 1 commit

• 8b2f0da7 - Add an explanation comment.

Compare with previous version

resolved all threads

added 1 commit

• f2bf9201 - It's not a possibility, it is a fact :)

Compare with previous version

This is testing twice with null as the non-string type. Why not add one example that is an array too?

I think it would be nice to test all possible non-string types here as a direct type and as part of the array with types. I suggest testing: int, float, array, boolean types. But for that, I have to refactor the data provider to \Generator, to make it more readable and easy to understand. Is that possible as part of this issue?

  public static function dataProviderValidateDefinitionInvalid(): \Generator {
    $valid_cta = static::loadComponentDefinitionFromFs('my-cta');

    $cta_with_missing_required = $valid_cta;
    unset($cta_with_missing_required['path']);
    yield 'missing required' => [$cta_with_missing_required];

    $cta_with_invalid_class = $valid_cta;
    $cta_with_invalid_class['props']['properties']['attributes']['type'] = 'Drupal\Foo\Invalid';
    yield 'invalid class' => [$cta_with_invalid_class];

    $cta_with_invalid_enum = array_merge(
      $valid_cta,
      ['extension_type' => 'invalid'],
    );
    yield 'invalid enum' => [$cta_with_invalid_enum];

    // A list of property types that are not strings, but can be provided via
    // YAML.
    $non_string_types = [NULL, 123, 123.45, TRUE];
    foreach ($non_string_types as $non_string_type) {
      $cta_with_non_string_prop_type = $valid_cta;
      $cta_with_non_string_prop_type['props']['properties']['text']['type'] = $non_string_type;
      yield "non string type ($non_string_type)" => [$cta_with_non_string_prop_type];

      // Same, but as a part of the list of allowed types.
      $cta_with_non_string_prop_type['props']['properties']['text']['type'] = ['string', $non_string_type];
      yield "non string type ($non_string_type) in a list of types" => [$cta_with_non_string_prop_type];
    }

    // The array is a valid value for the 'type' parameter, but it is not
    // allowed as the allowed type.
    $cta_with_non_string_prop_type['props']['properties']['text']['type'] = ['string', []];
    yield 'non string type (Array)' => [$cta_with_non_string_prop_type];
  }

I personally don't see why not!

changed this line in version 8 of the diff

added 175 commits

• f2bf9201...07abb808 - 174 commits from branch project:11.x
• 6a6b24d3 - Merge branch drupal:11.x into 3462156-unhelpful-php-error

Compare with previous version

added 1 commit

• c10e9703 - Improve data provider and cover more cases

Compare with previous version

added 1 commit

• ffd0f475 - Fix PHPCS

Compare with previous version

added 114 commits

• ffd0f475...9258113b - 113 commits from branch project:11.x
• a4b6c39c - Merge branch drupal:11.x into 3462156-unhelpful-php-error

Compare with previous version

added 1 commit

• 5f7ad929 - Change the return comment of ::dataProviderValidateDefinitionInvalid().

Compare with previous version

closed