Skip to content
Snippets Groups Projects

alternative

alternative
issue/drupal-2347867:2347867-mkII into 11.x
1 open thread
Open
mondrakerequested to merge
issue/drupal-2347867:2347867-mkII into 11.x
1 open thread

Closes #2347867

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/lib/Drupal/Core/Database/DatabaseConnectionInterface.php 0 → 100644
1 <?php
2
3 declare(strict_types=1);
4
5 namespace Drupal\Core\Database;
6
7 /**
8 * Interface for database connections.
9 */
10 interface DatabaseConnectionInterface {
  • Brad Jones
    Brad Jones @bradjones1

    I like the idea here and agree in principle that connections should be typehinted with an interface generally... the problem, though, is that the interface only declares a public API of open, which is rather incomplete. It seems that the path forward for moving to an interface would be adding all the public methods from Connection to this interface, adding a deprecation, etc. etc. - In the spirit of keeping this change narrow-ish, this is better as a follow-up?

  • M
    mondrake @mondrake
    Author Contributor

    ... or have no methods at all in the interface, so we can have free hands in the decorator. Emptied it here.

  • Please register or sign in to reply
  • mondrake added 5 commits

    added 5 commits

    • 8d6761a4...717b02a8 - 2 commits from branch project:11.x
    • 27645673 - Merge branch '11.x' into 2347867-mkII
    • a9d9047e - make interface empty
    • d232d097 - a simpler way to prevent non-transactional connections being opened

    Compare with previous version

    Toggle commit list
  • mondrake added 1 commit

    added 1 commit

    Compare with previous version

  • mondrake added 1 commit

    added 1 commit

    Compare with previous version

    • Please register or sign in to reply