Skip to content
Snippets Groups Projects

alternative

Open mondrake requested to merge issue/drupal-2347867:2347867-mkII into 11.x
1 unresolved thread

Closes #2347867

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline passed with warnings for 49436be1

Approval is optional
Code Quality is loading
Test summary results are being parsed
Merge blocked: 1 check failed

Merge details

  • The source branch is 880 commits behind the target branch.
  • 1 commit will be added to 11.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1 <?php
2
3 declare(strict_types=1);
4
5 namespace Drupal\Core\Database;
6
7 /**
8 * Interface for database connections.
9 */
10 interface DatabaseConnectionInterface {
  • I like the idea here and agree in principle that connections should be typehinted with an interface generally... the problem, though, is that the interface only declares a public API of open, which is rather incomplete. It seems that the path forward for moving to an interface would be adding all the public methods from Connection to this interface, adding a deprecation, etc. etc. - In the spirit of keeping this change narrow-ish, this is better as a follow-up?

  • Author Contributor

    ... or have no methods at all in the interface, so we can have free hands in the decorator. Emptied it here.

  • Please register or sign in to reply
  • mondrake added 5 commits

    added 5 commits

    • 8d6761a4...717b02a8 - 2 commits from branch project:11.x
    • 27645673 - Merge branch '11.x' into 2347867-mkII
    • a9d9047e - make interface empty
    • d232d097 - a simpler way to prevent non-transactional connections being opened

    Compare with previous version

  • mondrake added 1 commit
  • mondrake added 1 commit
  • Please register or sign in to reply
    Loading