Skip to content
Snippets Groups Projects

Issue #3056372: Primary dropbutton style update.

Open Issue #3056372: Primary dropbutton style update.
issue/drupal-3056372:3056372-primary-drop-button into 11.x
2 unresolved threads
Open Ahsan Nazir requested to merge issue/drupal-3056372:3056372-primary-drop-button into 11.x
2 unresolved threads

Closes #3056372

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #210386 passed

Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3056372

#210390

    Merge request pipeline passed for b91d83ae

    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.
    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/themes/claro/css/components/dropbutton.pcss.css
    41 41 .field-actions .dropbutton-wrapper {
    42 42 margin-block: var(--space-xs);
    43 43 margin-inline: 0 var(--space-m);
    44 margin: var(--space-m) var(--space-m) var(--space-m) 0;
  • Ben Mullins
    Ben Mullins @bnjmnm started a thread on the diff
    • core/themes/claro/css/components/dropbutton.pcss.css
    63 64 list-style: none;
    64 65 }
    65 66
    67 .dropbutton--primary .dropbutton__toggle {
    68 background: var(--button-bg-color--primary);
    69 }
    70
    71 .dropbutton--primary .dropbutton__toggle::before {
    72 background: url("data:image/svg+xml,%3Csvg width='14' height='9' viewBox='0 0 14 9' xmlns='http://www.w3.org/2000/svg'%3E%3Cpath d='M0.2384999,1.9384769 1.646703,0.5166019 7.0002189,5.8193359 12.353735,0.5166019 13.761938,1.9384769 7.0002189,8.635742Z' fill='white'/%3E%3C/svg%3E") no-repeat center;
    73 }
    74
    • Comment on lines +70 to +74
      Ben Mullins
      Ben Mullins @bnjmnm
      Maintainer

      Take a look at the toggle styling elsewhere in this file and you'll notice

      1. The svgs are not base64'd, they pull in a file background: url(../../images/icons/000f33/chevron-down.svg). In the transpiled version they will be automatically converted to base 64
      2. Nested selectors are used

      These additions should be consistent with that.

    • Please register or sign in to reply
  • Ahsan Nazir added 1 commit

    added 1 commit

    • b91d83ae - Primary dropbutton style update.

    Compare with previous version

    • Please register or sign in to reply