Issue #3384600: Deprecate and stop using EntityPermissionsRouteProviderWithCheck
Merge request reports
Activity
added 1 commit
- 47a2a068 - Fix failing test, use findConfigEntityDependenciesAsEntities
159 159 * 160 160 * @return \Drupal\Core\Access\AccessResultInterface 161 161 * The access result. 162 * 163 * @deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use changed this line in version 7 of the diff
159 159 * 160 160 * @return \Drupal\Core\Access\AccessResultInterface 161 161 * The access result. 162 * 163 * @deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use 164 * a permissions check in the route definition instead. 165 * @see https://www.drupal.org/node/3384745 162 166 */ 163 167 public function access(Route $route, RouteMatchInterface $route_match, $bundle = NULL): AccessResultInterface { 168 trigger_error(__CLASS__ . ':access() is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use a permissions check on the route definition instead. See https://www.drupal.org/node/3384745'); changed this line in version 7 of the diff
added 22 commits
-
df071a1d...9490eb3e - 15 commits from branch
project:11.x
- 5309ebe8 - commit patch, avoid phpstan error
- bfe770f5 - fix typo
- d550d4c9 - don't ignore
- c287dee2 - Fix failing test, use findConfigEntityDependenciesAsEntities
- 42882879 - Attempt to fix unit test
- 027e3a91 - changed deprecated/removed version numbers
- df2943ec - Added `E_USER_DEPRECATED`
Toggle commit list-
df071a1d...9490eb3e - 15 commits from branch
93 93 // Get the names of all config entities that depend on $this->bundle. 94 94 $config_name = $this->bundle->getConfigDependencyName(); 95 95 $config_entities = $this->configManager 96 ->getConfigEntitiesToChangeOnDependencyRemoval('config', [$config_name]); 96 ->findConfigEntityDependenciesAsEntities('config', [$config_name]); 97 97 $config_names = array_map( 98 98 function ($dependent_config) { 99 99 return $dependent_config->getConfigDependencyName(); 100 }, $config_entities['delete'] ?? [] 100 }, $config_entities - Comment on lines -96 to +100
#3306434 was fixed, and made a similar change to these lines. We can remove this change.
changed this line in version 10 of the diff
60 61 $module_handler = $this->prophesize(ModuleHandlerInterface::class)->reveal(); 61 62 $module_extension_list = $this->prophesize(ModuleExtensionList::class)->reveal(); 62 63 $prophecy = $this->prophesize(ConfigManagerInterface::class); 63 $prophecy->getConfigEntitiesToChangeOnDependencyRemoval('config', ['node.type.article']) 64 $prophecy->findConfigEntityDependenciesAsEntities('config', ['node.type.article']) 64 65 ->willReturn([ 65 'delete' => [ 66 66 new ConfigEntityDependency('core.entity_view_display.node.article.full'), 67 67 new ConfigEntityDependency('field.field.node.article.body'), 68 ], - Comment on lines -63 to -68
#3306434 was fixed, and made a similar change to these lines. We can remove this change.
added 82 commits
-
df2943ec...afdee270 - 76 commits from branch
project:11.x
- e79ee0c3 - commit patch, avoid phpstan error
- e64371c1 - fix typo
- 074938cc - don't ignore
- 9acb9511 - Fix failing test, use findConfigEntityDependenciesAsEntities
- 3f795e61 - changed deprecated/removed version numbers
- a7298253 - Added `E_USER_DEPRECATED`
Toggle commit list-
df2943ec...afdee270 - 76 commits from branch
added 30 commits
-
a7298253...c0e94e34 - 23 commits from branch
project:11.x
- da6d3bfe - commit patch, avoid phpstan error
- 26cca8b1 - fix typo
- 10e9ddbf - don't ignore
- ec1200e8 - Fix failing test, use findConfigEntityDependenciesAsEntities
- cc5289ea - changed deprecated/removed version numbers
- 03bef77e - Added `E_USER_DEPRECATED`
- ba90eb72 - Update test
Toggle commit list-
a7298253...c0e94e34 - 23 commits from branch
added 27 commits
-
b9b6ecb7...a6f5d7d3 - 19 commits from branch
project:11.x
- 2890d128 - commit patch, avoid phpstan error
- 11697923 - fix typo
- d924950c - don't ignore
- 8f155da2 - Fix failing test, use findConfigEntityDependenciesAsEntities
- ad2fd10e - changed deprecated/removed version numbers
- 5be10fd1 - Added `E_USER_DEPRECATED`
- a9d00186 - Update test
- 3363890b - Add expectDeprecation test
Toggle commit list-
b9b6ecb7...a6f5d7d3 - 19 commits from branch
added 13 commits
-
3363890b...2d94b30e - 5 commits from branch
project:11.x
- f6fd5ef9 - commit patch, avoid phpstan error
- e3a324a5 - fix typo
- 6812604e - don't ignore
- 3be0dd54 - Fix failing test, use findConfigEntityDependenciesAsEntities
- 87951826 - changed deprecated/removed version numbers
- 57bf5757 - Added `E_USER_DEPRECATED`
- dcfb982f - Update test
- 0b3b456c - Add expectDeprecation test
Toggle commit list-
3363890b...2d94b30e - 5 commits from branch
added 1 commit
- 0a000930 - Update comment to remove references to EntityPermissionsRouteProviderWithCheck
13 13 /** 14 14 * Provides routes for the entity permissions form. 15 15 * 16 * Use this class or EntityPermissionsRouteProviderWithCheck as a route 17 * provider for an entity type such as Vocabulary. Either one will provide 18 * routes for the entity permissions form. The 19 * EntityPermissionsRouteProviderWithCheck class provides a custom access check: 20 * it denies access if there are no entity-specific permissions. If you know 21 * that each entity has permissions, or if the check is too expensive, then use 22 * this class. 16 * Use this class as a route provider for an entity type such as Vocabulary. - Comment on lines -16 to +16
I would like to keep a little more of the comment. Just remove the part that compares this class to
EntityPermissionsRouteProviderWithCheck
. changed this line in version 17 of the diff
added 14 commits
-
0a000930...fbe398b5 - 5 commits from branch
project:11.x
- 3ab92ac8 - commit patch, avoid phpstan error
- 68c4447c - fix typo
- 561106dd - don't ignore
- b435a887 - Fix failing test, use findConfigEntityDependenciesAsEntities
- 6df5e551 - changed deprecated/removed version numbers
- 3d0fe009 - Added `E_USER_DEPRECATED`
- d84e99af - Update test
- 3eed802b - Add expectDeprecation test
- be20ad96 - Update comment to remove references to EntityPermissionsRouteProviderWithCheck
Toggle commit list-
0a000930...fbe398b5 - 5 commits from branch
Please register or sign in to reply