Skip to content
Snippets Groups Projects

Resolve #3456341 "View result counter"

Open Resolve #3456341 "View result counter"
issue/drupal-3456341:3456341-view-result-counter into 11.x
Open Pooja Sharma requested to merge issue/drupal-3456341:3456341-view-result-counter into 11.x

issue/3456341: Fixed View result counter as token not work, when use in Output this field as a custom link

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #365121 failed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3456341

#365123

    Merge request pipeline failed for 815ee464

    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.
    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/modules/views/tests/src/Kernel/Handler/FieldCounterTest.php
    133 133 $this->assertEquals('3', $counter);
    134 134
    135 135 $view->destroy();
    136 $view->storage->invalidateCaches();
    • Pooja Sharma
      Pooja Sharma @pooja_sharma
      Author

      same invalidateCaches() already used at line 57, also observed it can not be possible same view id can have two diff counter value at same time , may be it 'll be safer to add invalidateCaches() it.

      Edited by Pooja Sharma
    • Lee Rowlands
      Lee Rowlands @larowlan
      Maintainer

      It would be good to find out where the caching is coming from here. Is it at the view or row level? Why does this change mean we now have to invalidate the cache.

    • Please register or sign in to reply
  • Pooja Sharma added 37 commits

    added 37 commits

    • db4be911...b06bf11b - 25 commits from branch project:11.x
    • b06bf11b...ab9a2f9a - 2 earlier commits
    • 67cb858f - issue/3456341: updated test case fixing the issue.
    • 1c744b7c - issue/3456341: fixing View result counter as token not work, when use in...
    • 7945ee51 - issue/3456341: Addressed changes in Counter.php file
    • 05e51190 - issue/3456341: Updated render($row) function.
    • 1749bfac - issue/3456341: fixed cache issue in test case FieldCounterTest.php
    • d31eff3b - issue/3456341: fixed cache issue in test case RowRenderCacheTest
    • ecaf82be - issue/3456341: Added renderText() function.
    • a1c86825 - issue/3456341: Revert back changes in RowRenderCacheTest
    • 1ad3877f - issue/3456341: Added renderText() function.
    • 42196d34 - issue/3456341: Added cache API

    Compare with previous version

    Toggle commit list
  • Len Swaneveld
    Len Swaneveld @Lendude started a thread on an old version of the diff
    • core/modules/views/src/Plugin/views/field/Counter.php
    54 54 // do nothing -- to override the parent query.
    55 55 }
    56 56
    57 /**
    58 * {@inheritdoc}
    59 */
    60 public function renderText($alter) {
    61 $value = parent::renderText($alter);
    62 if ($value == '{{ counter }}') {
  • Pooja Sharma added 1 commit

    added 1 commit

    • 9a18fb63 - issue/3456341: Added getFieldTokenPlaceholder instead of hardcode counter.

    Compare with previous version

  • Pooja Sharma added 57 commits

    added 57 commits

    • 9a18fb63...bf4dfeaa - 44 commits from branch project:11.x
    • bf4dfeaa...a514d12b - 3 earlier commits
    • 2d85a9b7 - issue/3456341: fixing View result counter as token not work, when use in...
    • 5c1d39df - issue/3456341: Addressed changes in Counter.php file
    • a869c409 - issue/3456341: Updated render($row) function.
    • 8bb4fbb1 - issue/3456341: fixed cache issue in test case FieldCounterTest.php
    • 6e7c7a75 - issue/3456341: fixed cache issue in test case RowRenderCacheTest
    • b1e66151 - issue/3456341: Added renderText() function.
    • e1403d23 - issue/3456341: Revert back changes in RowRenderCacheTest
    • 16ed1f37 - issue/3456341: Added renderText() function.
    • d289c58f - issue/3456341: Added cache API
    • e8b4fdae - issue/3456341: Added getFieldTokenPlaceholder instead of hardcode counter.

    Compare with previous version

    Toggle commit list
  • Pooja Sharma added 45 commits

    added 45 commits

    • e8b4fdae...90f8dd19 - 32 commits from branch project:11.x
    • 90f8dd19...9d04cd85 - 3 earlier commits
    • ffad054f - issue/3456341: fixing View result counter as token not work, when use in...
    • d98b3d6f - issue/3456341: Addressed changes in Counter.php file
    • 915711a4 - issue/3456341: Updated render($row) function.
    • 6890c002 - issue/3456341: fixed cache issue in test case FieldCounterTest.php
    • f50d2f22 - issue/3456341: fixed cache issue in test case RowRenderCacheTest
    • bb500159 - issue/3456341: Added renderText() function.
    • 63acc3b1 - issue/3456341: Revert back changes in RowRenderCacheTest
    • 3807d138 - issue/3456341: Added renderText() function.
    • ff3a3934 - issue/3456341: Added cache API
    • 71c0a701 - issue/3456341: Added getFieldTokenPlaceholder instead of hardcode counter.

    Compare with previous version

    Toggle commit list
  • Pooja Sharma added 72 commits

    added 72 commits

    • 71c0a701...4c82b7ea - 59 commits from branch project:11.x
    • 4c82b7ea...cb6812c3 - 3 earlier commits
    • a31236be - issue/3456341: fixing View result counter as token not work, when use in...
    • 60e4d84d - issue/3456341: Addressed changes in Counter.php file
    • 6bd5208a - issue/3456341: Updated render($row) function.
    • a64b9703 - issue/3456341: fixed cache issue in test case FieldCounterTest.php
    • d28078ee - issue/3456341: fixed cache issue in test case RowRenderCacheTest
    • 2c5097f5 - issue/3456341: Added renderText() function.
    • 74e7eaca - issue/3456341: Revert back changes in RowRenderCacheTest
    • 053b83a8 - issue/3456341: Added renderText() function.
    • af058f0f - issue/3456341: Added cache API
    • 8dce9843 - issue/3456341: Added getFieldTokenPlaceholder instead of hardcode counter.

    Compare with previous version

    Toggle commit list
  • quietone added 1 commit

    added 1 commit

    Compare with previous version

  • Pooja Sharma added 153 commits

    added 153 commits

    • c22616d1...b81032f5 - 139 commits from branch project:11.x
    • b81032f5...43b0fc29 - 4 earlier commits
    • 0ffa2e21 - issue/3456341: Addressed changes in Counter.php file
    • eef7bc26 - issue/3456341: Updated render($row) function.
    • 3688330d - issue/3456341: fixed cache issue in test case FieldCounterTest.php
    • a54d907c - issue/3456341: fixed cache issue in test case RowRenderCacheTest
    • 5086879d - issue/3456341: Added renderText() function.
    • fdab6974 - issue/3456341: Revert back changes in RowRenderCacheTest
    • d6177d01 - issue/3456341: Added renderText() function.
    • cfa1ed4c - issue/3456341: Added cache API
    • de7e2a73 - issue/3456341: Added getFieldTokenPlaceholder instead of hardcode counter.
    • 94161a40 - Change some comments

    Compare with previous version

    Toggle commit list
  • Lee Rowlands
    Lee Rowlands @larowlan started a thread on the diff
    • core/modules/views/src/Plugin/views/field/Counter.php
    54 54 // Do nothing -- to override the parent query.
    55 55 }
    56 56
    57 /**
    58 * {@inheritdoc}
    59 */
    60 public function renderText($alter) {
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply