Skip to content
Snippets Groups Projects

Adds Administrator role and Content editor role recipes

Closes #3454605

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jim Birch added 1 commit

    added 1 commit

    • 1d7640e7 - Adds 'access content', moves node permissions to standard recipe.

    Compare with previous version

  • Jim Birch resolved all threads

    resolved all threads

  • Pooja Sharma added 1 commit

    added 1 commit

    • 916c00cf - issue/3454605: Fixed test failures.

    Compare with previous version

  • Pooja Sharma added 1 commit

    added 1 commit

    • 654034ac - issue/3454605: Fixed test failures case.

    Compare with previous version

  • 130 130 $expected_list = $comparer->getEmptyChangelist();
    131 131 // We expect core.extension to be different because standard is no longer
    132 132 // installed.
    133 $expected_list['update'] = ['core.extension'];
    133 $expected_list['update'] = ['core.extension', 'user.role.content_editor'];
    134 134 $this->assertSame($expected_list, $comparer->getChangelist());
    • Comment on lines 130 to 134

      I tried to figure out if anything update in permissions(remove/add even w.r.t to logic or not) in this file /core/recipes/content_editor_role/recipe.yml

      then 'user.role.content_editor' config included in the change list: $this->configImporter()->getStorageComparer()->getChangelist();

      To pass the test w.r.t to condition assertSame(), included 'user.role.content_editor' as well

      not sure may be need to update assertSame() condition, either added change 'll be fine, any other concerns?

      Edited by Pooja Sharma
    • We actually don't want to change this line. The thing we need to do is figure out why user.role.content_editor is changing, and alter our recipes in such a way that it doesn't get changed. The point of the Standard recipe set is that it should generate a site that is identical to the Standard profile.

    • I've been having similar thoughts but wasn't sure. Thanks for confirming & providing informative details for fixing issue.

    • Please register or sign in to reply
  • Pooja Sharma added 1 commit

    added 1 commit

    • 7e6c91c6 - issue/3454605: reverted the changes in test file.

    Compare with previous version

  • Adam G-H added 1 commit

    added 1 commit

    • 582687df - Fix permissions in wrong place

    Compare with previous version

  • Please register or sign in to reply
    Loading