First attempt, let's see what CI thinks of it.
Open
requested to merge issue/drupal-2719721:2719721-breadcrumbbuilderapplies-mismatch-with into 11.x
Closes #2719721
Merge request reports
Activity
added 1 commit
- 0e8fe5ec - Obviously we get a new cache set for the redirect to route.
added 1 commit
- 4c37729b - Chasing SPT as I can't run it on my local for the time being (it broke somehow)
171 171 $recorded_queries = $performance_data->getQueries(); 172 172 $this->assertSame($expected_queries, $recorded_queries); 173 173 $this->assertSame(12, $performance_data->getQueryCount()); 174 $this->assertSame(76, $performance_data->getCacheGetCount()); 175 $this->assertSame(15, $performance_data->getCacheSetCount()); 174 $this->assertSame(78, $performance_data->getCacheGetCount()); 175 $this->assertSame(16, $performance_data->getCacheSetCount()); 
The counts change because before we would get random cache contexts added to the built breadcrumbs. Now we get consistent cache contexts, a list which gets expanded upon as we go through non-applying builders. Because of this, cache redirects are introduced, which result in cache gets and sets.
- Resolved by Kristiaan Van den Eynde
- Resolved by Kristiaan Van den Eynde
- Resolved by Kristiaan Van den Eynde
- Resolved by Kristiaan Van den Eynde
- Resolved by Kristiaan Van den Eynde
- Resolved by Kristiaan Van den Eynde
added 1 commit
- 09773de1 - Use null safe operator as we may not receive a cacheable metadata (from a...
added 1 commit
- 742f53dc - Add back route cache context in builder for BC.
Please register or sign in to reply