Skip to content
Snippets Groups Projects

Icon or text - #3424744

Closed Ivan Berdinsky requested to merge issue/drupal-3424744:3424744-bcg-gradient into 11.x
1 unresolved thread

Closes #3424744

Merge request reports

Merged results pipeline passed for e948d246

Code Quality is loading
Test summary results are being parsed

Closed by Cristina ChumillasCristina Chumillas 9 months ago (May 31, 2024 8:32pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
119 // phpcs:disable
120 $links = [
121 1 => MenuLinkMock::create(['id' => 'test.example1', 'route_name' => 'example1', 'title' => 'title 1', 'parent' => '', 'weight' => 0]),
122 2 => MenuLinkMock::create(['id' => 'test.example2', 'route_name' => 'example2', 'title' => 'Another title', 'parent' => '', 'route_parameters' => ['foo' => 'bar'], 'weight' => 1]),
123 3 => MenuLinkMock::create(['id' => 'test.example3', 'route_name' => 'example3', 'title' => 'A menu link', 'parent' => 'test.example2', 'weight' => 2]),
124 ];
125 // phpcs:enable
126 foreach ($links as $instance) {
127 $this->menuLinkManager->addDefinition($instance->getPluginId(), $instance->getPluginDefinition());
128 }
129 }
130
131 /**
132 * Tests the generated HTML markup.
133 */
134 public function testToolbarButtonAttributes() {
  • added 1 commit

    • dbb86547 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Cristina Chumillas
  • 2 small design fixes:

    • On a design perspective the letters need to be centered, both vertically and horizontally.
    • For legibility purposes, this should use the first letter as capitalized, but not the second. The designs already have Caps + lower case. The reason is that lower case's shapes are way better to recognize.
  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Cristina Chumillas
  • 2 small design fixes:

    • On a design perspective the letters need to be centered, both vertically and horizontally.
    • For legibility purposes, this should use the first letter as capitalized, but not the second. The designs already have Caps + lower case. The reason is that lower case's shapes are way better to recognize.
  • added 1 commit

    • 6e9c32a9 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 0cf487f1 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Please register or sign in to reply
    Loading