Add EOL and warning dates for 10.5 and 10.6.
3 unresolved threads
3 unresolved threads
Closes #3378393
Merge request reports
Activity
added 13 commits
-
7d8a4db7...34abc72b - 9 commits from branch
project:10.4.x - fe6804b0 - Add EOL and warning dates for 10.5 and 10.6.
- 9284dc9d - Update fixtures and test for D10.
- 326fd608 - Correct EOL and warning dates for 10.6.
- 5ce429a9 - Mock the curret time
Toggle commit list-
7d8a4db7...34abc72b - 9 commits from branch
added 2 commits
added 404 commits
-
c25e2e16...02bd9df6 - 398 commits from branch
project:10.4.x - 1dd9b9ff - Add EOL and warning dates for 10.5 and 10.6.
- 33d6dfaa - Update fixtures and test for D10.
- 124cb9b9 - Correct EOL and warning dates for 10.6.
- 2723159e - Mock the curret time
- 3eba1efe - put warning date in range
- 0dabe486 - there is coverage on the end date
Toggle commit list-
c25e2e16...02bd9df6 - 398 commits from branch
221 221 } 222 222 223 223 $comparable_request_date = $date_formatter->format($time->getRequestTime(), 'custom', $date_format); 224 if ($this->securityCoverageInfo['security_coverage_end_date'] <= $comparable_request_date) { 224 if ($this->securityCoverageInfo['security_coverage_end_date'] < $comparable_request_date) { -
It's not immediately clear why the logic is changing here (now using
<instead of<=). Seems a bit out of scope to change this to start warning "Coverage has ended" on the last day we say you have coverage...I figured out why this was changed, and I think it's due to an error in the fixture changes. I'll start another thread there to be easier to follow...
changed this line in version 10 of the diff
175 '10.5.0, supported, 6 months warn' => [ 176 'installed_version' => '10.5.0', 177 'fixture' => 'sec.10.6.0', 178 178 'requirements_section_heading' => 'Warnings found', 179 'message' => "Covered until 2023-Jun-21 $update_soon_message $release_coverage_message", 180 'mock_date' => '2022-12-14', 179 'message' => "Covered until 2026-Jun-17 $update_soon_message $release_coverage_message", 180 'mock_date' => '2025-12-10', 181 181 ], 182 182 ]; 183 183 // Ensure that the message does not change, including on the last day of 184 184 // security coverage. 185 $test_cases['9.4.0, supported, last day warn'] = $test_cases['9.4.0, supported, 6 months warn']; 186 $test_cases['9.4.0, supported, last day warn']['mock_date'] = '2023-06-20'; 185 $test_cases['10.5.0, supported, last day warn'] = $test_cases['10.5.0, supported, 6 months warn']; 186 $test_cases['10.5.0, supported, last day warn']['mock_date'] = '2026-06-17'; - Comment on lines -186 to +186
Currently in 10.4.x branch, we have:
const SECURITY_COVERAGE_END_DATE_9_4 = '2023-06-21';So the mock here used
2023-06-20for testing the "last day".The new const is:
const SECURITY_COVERAGE_END_DATE_10_5 = '2026-06-17';so we should be using
2026-06-16here. Then we wouldn't have to change the logic above. changed this line in version 10 of the diff
208 $test_cases['10.6.0, supported, 6 months warn'] = [ 209 'installed_version' => '10.6.0', 210 'fixture' => 'sec.10.6.0', 211 211 'requirements_section_heading' => 'Warnings found', 212 'message' => "Covered until 2023-Nov $update_soon_message $release_coverage_message", 213 'mock_date' => '2023-05-15', 212 'message' => "Covered until 2026-Dec-09 $update_soon_message $release_coverage_message", 213 'mock_date' => '2026-06-17', 214 214 ]; 215 215 216 216 // Ensure that the message does not change, including on the last day of 217 217 // security coverage. 218 $test_cases['9.5.0, supported, last day warn'] = $test_cases['9.5.0, supported, 6 months warn']; 219 $test_cases['9.5.0, supported, last day warn']['mock_date'] = '2023-10-31'; 218 $test_cases['10.6.0, supported, last day warn'] = $test_cases['10.6.0, supported, 6 months warn']; 219 $test_cases['10.6.0, supported, last day warn']['mock_date'] = '2026-12-09'; changed this line in version 10 of the diff
added 35 commits
-
d61163e3...1630e53c - 28 commits from branch
project:10.4.x - bd29dc63 - Add EOL and warning dates for 10.5 and 10.6.
- 601705ad - Update fixtures and test for D10.
- ffb6a12f - Correct EOL and warning dates for 10.6.
- 22739bd1 - Mock the curret time
- fff21627 - put warning date in range
- d0a5c0d4 - there is coverage on the end date
- c2ca11e4 - respond to feedback
Toggle commit list-
d61163e3...1630e53c - 28 commits from branch
added 10 commits
-
c2ca11e4...af72eee4 - 3 commits from branch
project:10.4.x - 6911ab6e - Add EOL and warning dates for 10.5 and 10.6.
- b5b8c45a - Update fixtures and test for D10.
- 8fbab660 - Correct EOL and warning dates for 10.6.
- 4b81110e - Mock the curret time
- 78f4ad24 - put warning date in range
- 1afeed68 - there is coverage on the end date
- 5222ba22 - respond to feedback
Toggle commit list-
c2ca11e4...af72eee4 - 3 commits from branch
Please register or sign in to reply