Skip to content
Snippets Groups Projects

Update paths on quick start recipe command

Closed Richard Allen requested to merge issue/drupal-3445847:3445847-phpunit-10-chdir-retry into 11.x
All threads resolved!

I'm happy to report that with these changes "Recipe Quick Start" reports green without any warnings (at least locally).

I am submitting a merge request so that I can test against the full test suite on Gitlab.

I saw that @catch just updated 11.0.x today, so I rebased and applied the changes on the tip of that. The original MR was done on 11.0.x, but then changed to 11.x, so I'm changing this MR to 11.x as well (thanks @larowlan for the branch clarification)

  • The "re-rolled patch" should include all previous changes by @mstrelan.
  • I am following the same pattern established by mstrelan in #3445847.
  • Updated testQuickStartRecipeCommand() to use $this->root.
  • My changes are only for tests/Drupal/Tests/Core/Recipe/RecipeQuickStartTest.php.

Local result:

image

Edited by Richard Allen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Richard Allen resolved all threads

    resolved all threads

  • Richard Allen changed target branch from 11.0.x to 11.x

    changed target branch from 11.0.x to 11.x

  • Richard Allen changed the description

    changed the description

  • Richard Allen added 81 commits

    added 81 commits

    Compare with previous version

  • added 1 commit

    • 4a9a7b9f - Issue #3445847 by mstrelan, Alexander Allen, catch: PHPUnit 10 behaves...

    Compare with previous version

  • added 1 commit

    • a600fcd9 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Michael Strelan added 87 commits

    added 87 commits

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading