Issue #3439909 by SolimanHarkas, vensires: Fix Taxonomy tests that rely on...
1 unresolved thread
Merge request reports
Activity
added 58 commits
-
b3a83764...0a4f122f - 57 commits from branch
project:11.x - ac64507c - Initial exploration of setting correct max-age on cache records.
-
b3a83764...0a4f122f - 57 commits from branch
added 1 commit
- f9a0db7f - When calculating max-age the code should use: expire-time minus current time.
added 1 commit
- e03006e6 - Mock the added time argument to the accesspolicy tests
added 1 commit
- ce0c1a4b - Mock the added time argument to the accesspolicy tests
added 106 commits
-
ce0c1a4b...d246c433 - 103 commits from branch
project:11.x - 74d4b890 - Initial exploration of setting correct max-age on cache records.
- ddcbb98c - When calculating max-age the code should use: expire-time minus current time.
- 7f98ba7b - Mock the added time argument to the accesspolicy tests
Toggle commit list-
ce0c1a4b...d246c433 - 103 commits from branch
added 454 commits
-
f98d6018...802d56e8 - 450 commits from branch
project:11.x - fb5ae71e - Initial exploration of setting correct max-age on cache records.
- 2eb32264 - When calculating max-age the code should use: expire-time minus current time.
- b71f107d - Mock the added time argument to the accesspolicy tests
- c0ed9e46 - Fix cs
Toggle commit list-
f98d6018...802d56e8 - 450 commits from branch
78 84 try { 79 85 // Retrieve the permissions from the static cache if available. 80 86 if ($static_cache = $this->variationStatic->get($cache_keys, $initial_cacheability)) { 87 // @todo How to handle this? -
There are three cases where a result is returned from this method:
- There is no cached result, so it is computed fresh.
- There is a cached result from a different request.
- There is a cached result from the current request.
The first case doesn't matter, because the cache will be guaranteed to have the correct max age. You've already taken care of the second case which is functionally similar to the DPC/render cache changes. The third case will implicitly be correct as long as the other cases are both correct.
I don't think we need to do anything special here.
changed this line in version 11 of the diff
added 1041 commits
-
c22cf51b...05b8266c - 1035 commits from branch
project:11.x - 47eb8c77 - Initial exploration of setting correct max-age on cache records.
- 547bdc4b - When calculating max-age the code should use: expire-time minus current time.
- 8481bb34 - Mock the added time argument to the accesspolicy tests
- 2a991a1e - Fix cs
- dc1dc1b3 - Update deprecation message
- 70cb8ebf - round out access policy processor max age adjustment
Toggle commit list-
c22cf51b...05b8266c - 1035 commits from branch
Please register or sign in to reply