Skip to content
Snippets Groups Projects

Issue 3443810: added extra steps for the preprocess navigation hook to ensure...

Closed Issue 3443810: added extra steps for the preprocess navigation hook to ensure...
issue/drupal-3443810:3443810-custom-nav-logo-disconnect-fix into 11.x
1 unresolved thread
Closed Jera Perry requested to merge issue/drupal-3443810:3443810-custom-nav-logo-disconnect-fix into 11.x
1 unresolved thread

Issue 3443810: added extra steps for the preprocess navigation hook to ensure the needed logo variables are available for the template.

Closes #3443810

Merge request reports

Merge request pipeline #168994 failed

Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3443810

#169000

    Merge request pipeline failed for bce68668

    Approval is optional
    Code Quality is loading
    Test summary results are being parsed
    Full report

    Closed by Théodore BiadalaThéodore Biadala 8 months ago (Jun 13, 2024 8:41pm UTC)

    Merge details

    • The changes were not merged into 11.x.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/modules/navigation/navigation.module
    212 212 */
    213 213 function template_preprocess_navigation(array &$variables): void {
    214 214 $variables['hide_logo'] = $variables['content']['#hide_logo'] ?? TRUE;
    215 $page_top = [];
    • skaught
      skaught @SKAUGHT ·

      Jera: All of the work is on the other branch to fix the bug itself, including not using a hook here anymore as the NavigationRender has charge the layout template itself.

      It is the tests that need to be completed from that point of work, can you help with there?

    • J
      Jera Perry @jrperry ·
      Author

      @SKAUGHT yea I can go ahead and help with any other applicable tests. I did a fix here on the hook as I wasn't able to verify any other place where this change could have feasibly went to. I'll reach out to you directly through Slack or some other means.

    • Please register or sign in to reply
  • Jera Perry added 1 commit

    added 1 commit

    • bce68668 - Issue 3443810: ensured the code follows Drupal PHP coding standards.

    Compare with previous version

  • Théodore Biadala closed

    closed

    • Please register or sign in to reply