Issue #3445375: Test to reproduce this issue
Closes #3445375
Merge request reports
Activity
added 3 commits
-
7fa23288...4a4a78b5 - 2 commits from branch
project:11.x
- 4bdd3080 - Merge branch drupal:11.x into 3445375-11-x
-
7fa23288...4a4a78b5 - 2 commits from branch
added 1 commit
added 20 commits
-
163590f9...6293c8e0 - 19 commits from branch
project:11.x
- 14644df0 - Merge branch drupal:11.x into 3445375-11-x
-
163590f9...6293c8e0 - 19 commits from branch
added 2 commits
added 5 commits
-
8baaecb6...c27cc9b8 - 4 commits from branch
project:11.x
- 7b04777f - Merge branch drupal:11.x into 3445375-11-x
-
8baaecb6...c27cc9b8 - 4 commits from branch
- Resolved by Mingsong
- Resolved by Mingsong
176 177 * An array of overlapping tags. 177 178 * @param \Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition[] $plugin_definitions 178 179 * An array of plugin definitions where overlap was found. 179 * @param \Drupal\ckeditor5\HTMLRestrictions $enabled_plugin_restrictions 180 * The set of HTML restrictions for all already enabled CKEditor 5 plugins. 180 * @param bool $is_attr_overlap 181 * Whether is attribute overlapped. 181 182 * 182 183 * @return string 183 184 * A list of plugins that provide the overlapping tags. 184 185 */ 185 private function pluginsSupplyingTagsMessage(HTMLRestrictions $overlap, array $plugin_definitions, HTMLRestrictions $enabled_plugin_restrictions): string { 186 private function pluginsSupplyingTagsMessage(HTMLRestrictions $overlap, array $plugin_definitions, bool $is_attr_overlap): string { 186 187 $message_array = []; 187 188 $message_string = ''; 189 Thanks @smustgrave for the review. The new parameter
$is_attr_overlap
is critical to the bug fix as it required by the additional checking.
Please register or sign in to reply