Skip to content
Snippets Groups Projects

Draft: Core config + Icons set POC + SDC

1 unresolved thread

Closes #3432173

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
41 42 - core/once
42 43 - core/drupal.displace
43 44
45 icons:
46 css:
47 base:
48 https://unpkg.com/@phosphor-icons/web@2.1.1/src/regular/style.css: { type: external, minified: true }
  • I'm not sure about adding another external dependency... Plus there could easily be people adding their own custom svg/png like a specific internal logo.

  • from template class="ph ph-{{ navigation_icon }} toolbar-button__icon">

    • add setting to form with (main) navigation settings the library prefix. this is general responsibility of the admin to use a prefix that is available (until there is a greater Icons solution in core).
    options: navigation_type: 'library'. // library|file navigation_icon: 'megaphone' navigation_fid: 0, //. zero would stand for no file attached. - add file selection to NavigationBlock (settings tray) level selection for currently selected 1st level items.
    Edited by skaught
  • Author Contributor

    I've added simplest use case. Library should be attached. And well documented outside. It can be scaled to custom libs later.

    Edited by Ivan Berdinsky
  • Ivan Berdinsky changed this line in version 2 of the diff

    changed this line in version 2 of the diff

  • Please register or sign in to reply
  • skaught
  • Ivan Berdinsky added 123 commits

    added 123 commits

    Compare with previous version

  • Ivan Berdinsky added 1 commit

    added 1 commit

    • 1ac3e625 - Core config + Icons set POC + SDC

    Compare with previous version

  • Ivan Berdinsky changed title from Draft: Core config + Icons set POC to Draft: Core config + Icons set POC + SDC

    changed title from Draft: Core config + Icons set POC to Draft: Core config + Icons set POC + SDC

  • Gaurav added 1 commit

    added 1 commit

    • 09e03c78 - material symobl label trans filter added

    Compare with previous version

  • Mithun S added 1 commit

    added 1 commit

    • bed83f7d - 3432173: Fix the PHPCS issue occuring on the files.

    Compare with previous version

  • Please register or sign in to reply
    Loading