Skip to content
Snippets Groups Projects

Add new GetDocumentFromRequestTrait to simplify getting document from response...

All threads resolved!

Add new GetDocumentFromRequestTrait to simplify getting document from response and allow readable failure when there is no data.

Closes #3440993

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #161002 passed

Merge request pipeline passed for feef2b37

Code Quality is loading
Test summary results are being parsed
Ready to merge by members who can write to the target branch.

Merge details

  • The source branch is 1784 commits behind the target branch.
  • 1 commit will be added to 11.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • quietone
  • quietone
  • Björn Brala added 1 commit

    added 1 commit

    • 20b1a33d - Rename parameter to validate

    Compare with previous version

  • Björn Brala resolved all threads

    resolved all threads

  • Björn Brala added 1 commit

    added 1 commit

    • 84569c3d - Use a better vairbale name for the patched_document

    Compare with previous version

  • Björn Brala added 1 commit

    added 1 commit

    • 2c47b2ed - Fixup argument with phpdoc and rename from 'validated' to verb 'validate'

    Compare with previous version

  • Björn Brala resolved all threads

    resolved all threads

  • Björn Brala added 699 commits

    added 699 commits

    • 2c47b2ed...6efa692f - 689 earlier commits
    • cc356710 - Add second class that calls this Trait. Needs assert because of $this->fail calls.
    • fc10b496 - Typo in regression test
    • 87cda7af - All classes end up in BrowserTestBase
    • 3bd7273a - Stop asserting if data is present on test that tests an error.
    • 560cb2a3 - Prettyfy error a little
    • 35ed8a41 - Some nit updates to new trait
    • 99cd3e43 - JSON decode can be NULL and this is expected in some tests.
    • 8e957690 - Rename parameter to validate
    • 6bffd044 - Use a better vairbale name for the patched_document
    • e4a60a8c - Fixup argument with phpdoc and rename from 'validated' to verb 'validate'

    Compare with previous version

  • Björn Brala changed target branch from 10.3.x to 11.x

    changed target branch from 10.3.x to 11.x

  • Björn Brala added 13 commits

    added 13 commits

    • e4a60a8c...f622cb77 - 3 earlier commits
    • 5743202a - Move getDocumentFromReponse before httpcode checks
    • 4b1b1053 - Also handle null value, when data is expected and no errors have been found,...
    • 1ae54e77 - All classes end up in BrowserTestBase
    • 688da086 - Stop asserting if data is present on test that tests an error.
    • 4364fb2b - Prettyfy error a little
    • 096eefc8 - Some nit updates to new trait
    • 7ff01ac6 - JSON decode can be NULL and this is expected in some tests.
    • fb913b96 - Rename parameter to validate
    • 81ea7cd8 - Use a better var name for the patched_document
    • 47fdebee - Fixup argument with phpdoc and rename from 'validated' to verb 'validate'

    Compare with previous version

  • Björn Brala added 15 commits

    added 15 commits

    • 47fdebee...d91d06ea - 5 earlier commits
    • 2776d413 - Move getDocumentFromReponse before httpcode checks
    • c64d902e - Also handle null value, when data is expected and no errors have been found,...
    • eb231800 - All classes end up in BrowserTestBase
    • 7dba7260 - Stop asserting if data is present on test that tests an error.
    • 7c76e18a - Prettyfy error a little
    • af0907d9 - Some nit updates to new trait
    • f76e567b - JSON decode can be NULL and this is expected in some tests.
    • 7c2f7563 - Rename parameter to validate
    • 57514508 - Use a better var name for the patched_document
    • f3649507 - Fixup argument with phpdoc and rename from 'validated' to verb 'validate'

    Compare with previous version

  • This is great. We should have done it long ago! Just one minor change to the trait that I think will make it useful for other testing setups (e.g. DTT)

  • Björn Brala added 1 commit

    added 1 commit

    • 0ca05484 - Move interface check up the chain to TestCase to allow this trait to be used...

    Compare with previous version

  • Björn Brala resolved all threads

    resolved all threads

  • Björn Brala added 1 commit

    added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading