[#2640994] fix(views): Consolidate all entity reference arguments into a single plugin, fix label token replacement
- Consolidate all entity reference arguments into a single
EntityArgument
plugin. - BC provided for all the legacy ways these plugins could be instantiated or accessed
- Remove a bunch of (nearly) duplicate code
- Improve consistency and functionality while reducing technical debt
- Add an
EntityReferenceArgument
(entity_target_id
) plugin that correctly handles title token replacement - Provide
post_update()
method to set all entity reference arguments fromnumeric
toentity_target_id
Suggested commit message:
[#2640994] fix(views): Consolidate all entity reference arguments into a single plugin, fix label token replacement
Authored-by: dww <git@dwwright.net>
Authored-by: tduong
Authored-by: Alex Bukach
Authored-by: Berdir
Authored-by: ameymudras
Authored-by: catch
Authored-by: Mohit Aghera <mohit.beta@gmail.com>
Edited by Derek Wright
Merge request reports
Activity
added 1 commit
added 1 commit
added 1 commit
added 1 commit
added 23 commits
-
a950c1d9...d2509584 - 12 commits from branch
project:10.3.x
- 88f71b94 - 1 earlier commit
- ae4089c3 - Use attribute for the new plugin.
- 8a46e02a - Phpstan fixes.
- 4d9732b0 - [#2640994] Remove stale config from view.test_entity_id_argument.yml
- 524d6d88 - [#2778345]: Convert post_update to use ViewsConfigUpdater
- 618af199 - [#2778345]: Regenerate view.test_entity_id_argument_update.yml fixture with 10.2.x core
- e91b235c - [#2778345]: Remove unused use in views.post_update.php
- 13d65997 - [#2778345]: Fix bug in ViewsConfigUpdater where we assumed argument plugins too early
- 1dfd0116 - [#2778345]: Make ViewsConfigUpdater more resiliant to incomplete config
- 71ed94f6 - [#2778345]: Update Umami's views.view.related_recipes.yml to use entity_target_id argument plugin
- d56db043 - [#2778345]: Remove now-irrelevant ViewsArgumentDeprecationTest
Toggle commit list-
a950c1d9...d2509584 - 12 commits from branch
added 5 commits
- 96ac3af2 - [#2778345]: Fix some nits in EntityArgumentTest
- 2e58010b - [#2778345]: Fix some nits in EntityArgumentUpdateTest
- 799dd2c4 - [#2778345]: Standardize on 1-line classes to extend EntityArgument:
- 2a51feba - [#2778345]: Safely handle deprecated constructor params and property access in EntityArgument:
- 2fb527ea - [#2778345]: Fix ViewsArgumentDeprecationTest to behave like the old Taxonomy...
Toggle commit listadded 4 commits
- e8add2a9 - [#2778345]: Fix phpcs, phpstan, and cspell errors in EntityArgument from commit 415a32b5 ;)
- c6e4aa4f - [#2778345]: Remove unused used from TaxonomyViewsArgumentTest
- 7b033eed - [#2778345]: Fix typo in TaxonomyViewsArgumentTest
- 625d1e92 - [#2778345]: Per Slack with @mstrelan phpstan won't know the type of promoted...
Toggle commit list- Resolved by Derek Wright
- Resolved by Derek Wright
- Resolved by Derek Wright
- Resolved by Derek Wright
- Resolved by Derek Wright
- Resolved by Derek Wright
- Resolved by Derek Wright
Please register or sign in to reply