Skip to content
Snippets Groups Projects

remove deprecated in utilities

Closed quietone requested to merge issue/drupal-3441394:3441394-remove-deprecated-code into 11.x
3 unresolved threads

Closes #3441394

Merge request reports

Merge request pipeline #157574 passed

Merge request pipeline passed for a83afd84

Approval is optional
Code Quality is loading
Test summary results are being parsed

Closed by catchcatch 1 year ago (Apr 26, 2024 2:40pm UTC)

Merge details

  • The changes were not merged into 11.x.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
133 124 // Add a "data-drupal-link-system-path" attribute to let the
134 125 // drupal.active-link library know the path in a standardized manner.
135 126 if ($url->isRouted() && !isset($variables['options']['attributes']['data-drupal-link-system-path'])) {
136 // @todo System path is deprecated - use the route name and parameters.
137 127 $system_path = $url->getInternalPath();
  • 430 426 * @ingroup sanitization
    431 427 */
    432 428 public static function escape($text): string {
    433 if (is_null($text)) {
  • catch @catch started a thread on the diff
  • 133 124 // Add a "data-drupal-link-system-path" attribute to let the
    134 125 // drupal.active-link library know the path in a standardized manner.
    135 126 if ($url->isRouted() && !isset($variables['options']['attributes']['data-drupal-link-system-path'])) {
    136 // @todo System path is deprecated - use the route name and parameters.
    • Maintainer

      The @todo is no less valid than it was previously. What it's saying is it wants to change the active link library library to rely on route name and parameters instead of system path. However, this should be an issue rather than a @todo so I will tag for follow-up.

    • Please register or sign in to reply
  • Stephen Mustgrave added 59 commits

    added 59 commits

    • 45f71098...66de90c6 - 57 commits from branch project:11.x
    • 25dff236 - Merge branch '11.x' of git.drupal.org:project/drupal into 3441394-remove-deprecated-code
    • 3ed93e4c - Add comment back with issue

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading