Skip to content
Snippets Groups Projects

Only load the system module's theme information during UpdateKernel

2 unresolved threads

Closes #3441222

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 311 311 */
    312 312 $settings['update_free_access'] = FALSE;
    313 313
    314 /**
    315 * Limits the modules to build the theme registry for on update.php.
  • 311 311 */
    312 312 $settings['update_free_access'] = FALSE;
    313 313
    314 /**
    315 * Limits the modules to build the theme registry for on update.php.
    316 *
    317 * Because update.php needs to render things, the theme registry is built. Some
    318 * modules such as Views need to load a lot of data to build this registry and
    319 * some of that data may be unstable until the updates are ran. By default, the
    320 * list of modules is reduced to just system, but you can add to this list or
    321 * set the setting to FALSE to have all modules loaded.
    • Comment on lines +317 to +321

      Similar here. But the 'some bad things from happening' should be explained. In general, I think more information is needed to help someone decide when to they should change this setting.

      "Before an update is executes the theme registry is built. Some of that data for an extension may only be stable after the update has completed. To prevent 'some bad things from happening' only the System Module is used to build the theme registry during an update. More modules can be added, if needed. Set this setting to FALSE to have all modules used to build the theme registry."

    • Kristiaan Van den Eynde changed this line in version 12 of the diff

      changed this line in version 12 of the diff

    • I tried rewriting it, please verify

    • Please register or sign in to reply
  • added 3 commits

    • 0ecdc3c0 - Use dependency injection
    • 73a95752 - Update docs, hopefully better this way
    • ba7a36b3 - Update the logic for limiting the list of modules

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 17e0cfb0 - Fix kernel tests and a mistake

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Kristiaan Van den Eynde changed target branch from 11.x to 10.3.x

    changed target branch from 11.x to 10.3.x

  • Kristiaan Van den Eynde changed target branch from 10.3.x to 10.4.x

    changed target branch from 10.3.x to 10.4.x

  • Kristiaan Van den Eynde changed target branch from 10.4.x to 11.x

    changed target branch from 10.4.x to 11.x

  • added 1 commit

    • 0c01832c - Change order of parameters so it's nicer post-deprecation

    Compare with previous version

  • added 1 commit

    • e32bc37f - Minor test fix after order change

    Compare with previous version

  • added 115 commits

    • e32bc37f...01da0fd9 - 114 commits from branch project:11.x
    • 8440743b - Merge remote-tracking branch 'origin/11.x' into 3441222-trying-to-repair

    Compare with previous version

  • added 20 commits

    • 8440743b...4556add5 - 18 commits from branch project:11.x
    • c71520bb - Merge remote-tracking branch 'origin/11.x' into 3441222-trying-to-repair
    • 76667fa9 - Do not allow using a theme for update.php if it depends on modules.

    Compare with previous version

  • added 1 commit

    • f2e5c13b - Don't break tests that didn't set the active themes.

    Compare with previous version

  • added 1 commit

    • 549fa75e - Switch back to hard-coding system as a BC break might be warranted here after all.

    Compare with previous version

  • added 1 commit

    • d89328f5 - Forgot to remove use statement

    Compare with previous version

  • added 1 commit

    • a6733971 - Remove test that was for setting

    Compare with previous version

  • nicxvan added 2 commits

    added 2 commits

    Compare with previous version

  • added 1 commit

    • e6f7c516 - Rewrote comment to stay below 80 character limit.

    Compare with previous version

  • Please register or sign in to reply
    Loading