Resolve #3437319 "Add validation constraints to update.settings"

Closes #3437319

added 1 commit

• 612b45db - update path test

Compare with previous version

added 1 commit

• 525efa04 - removed unnecessary constraints

Compare with previous version

added 1 commit

• 6b680b7d - Fixed config target

Compare with previous version

added 1 commit

• 17766618 - Fixed failing test

Compare with previous version

added 20 commits

• 17766618...a5fe7e9f - 10 earlier commits
• 16bfbca5 - Issue #3088643 by amateescu, Gábor Hojtsy, catch, smustgrave: Mark Workspaces...
• 0ebc8748 - Issue #3295078 by quietone, dww, AaronMcHale, Anybody, benjifisher, andregp,...
• 5ff99ad5 - Issue #3227518 by kunal.sachdev, quietone, tedbow, ravi.shankar, gisle,...
• a71547f5 - Issue #3127168 by quietone, tedbow, dww: Create contrib Update test for legacy to semver releases
• 91d1a2fc - Issue #3439899 by SolimanHarkas, vensires: Fix Menu tests that rely on UID1's super user behavior
• 07f3bb88 - Issue #3439924 by SolimanHarkas, vensires: Fix Minimal profile tests that rely...
• 0880b5ea - Issue #1766338 by vasike, John Pitcairn, sagesolutions, jenlampton, ckaotik,...
• 25c98354 - Issue #3389688 by kim.pepper, smustgrave, alexpott, quietone: Add a trait to...
• 8bd4a7f5 - Issue #3439527 by acbramley, smustgrave, alexpott: Add type hints to...
• f6771889 - revert unnecessary changes

Compare with previous version

added 1 commit

• e34c9f93 - revert unnecessary changes

Compare with previous version

added 1 commit

• fce132fb - remove nullable from notification.emails in favor of empty array

Compare with previous version

resolved all threads

I don't think timeout being set to 0 would result in a well-working application: if I read \Drupal\update\UpdateProcessor::fetchData() correctly, it might result in no update data being fetched, or perhaps a single item. A single item would be fine, zero would not be.

I think 1 would probably be a better minimum, but there's no real harm caused by this — the status report would still end up complaining about updates not having been checked in a long time. Which could also happen if the timeout was set to 1 and d.o is slow and/or the server hosting the Drupal application has a slow internet connection.

So … not commit-blocking IMHO.