Deprecation for dialogClass
Closes #3296098
Merge request reports
Activity
added 1 commit
- d375c5b8 - Rework the bc layer so we don't trigger the deprecation in the parent class.
added 1 commit
- 28aac0e5 - Update usages to use classes instead of dialogClass
- Resolved by catch
- Resolved by catch
40 40 public function __construct(string|\Stringable|null $title, $content, array $dialog_options = [], $settings = NULL, $position = 'side') { 41 $dialog_class = NULL; 42 if (isset($dialog_options['classes']['ui-dialog'])) { 43 $dialog_class = $dialog_options['classes']['ui-dialog']; 44 } 45 elseif (isset($dialog_options['dialogClass'])) { 46 @trigger_error('Passing $dialog_options[\'dialogClass\'] to OpenOffCanvasDialogCommand::__construct() is deprecated in drupal:10.3.0 and will be removed in drupal:12.0.0. Use $dialog_options[\'classes\'] instead. See https://www.drupal.org/node/3440844', E_USER_DEPRECATED); 47 $dialog_class = $dialog_options['dialogClass']; 48 unset($dialog_options['dialog_class']); 49 } 50 if ($dialog_class) { 51 $dialog_options['classes']['ui-dialog'] = $dialog_class . ' ' . "ui-dialog-off-canvas ui-dialog-position-$position"; 52 } 53 else { 54 $dialog_options['classes']['ui-dialog'] = "ui-dialog-off-canvas ui-dialog-position-$position"; 55 } - Comment on lines +50 to +55
49 if ($dialog_class) { 50 $dialog_options['classes']['ui-dialog'] = $dialog_class . ' ' . "ui-dialog-off-canvas ui-dialog-position-$position"; 51 } 52 else { 53 $dialog_options['classes']['ui-dialog'] = "ui-dialog-off-canvas ui-dialog-position-$position"; 54 } 49 $dialog_options['classes']['ui-dialog'] = "$dialog_class ui-dialog-off-canvas ui-dialog-position-$position"; 50 maybe? Should work, we just need to define
$dialog_class = ''
instead of null changed this line in version 15 of the diff
added 1 commit
- 5375d259 - Always trigger_error() if dialogClass is passed in.
- Resolved by catch
added 1 commit
- 4a2f5b9a - Remove the unset since it's not strictly necessary.
- Resolved by catch
added 1 commit
- b1e926ff - Merge instead of overwriting classes when both are set.
Please register or sign in to reply